fix(validators): allow GitLab URLs with nested subgroups#1452
Open
truecallerabreham wants to merge 1 commit into
Open
fix(validators): allow GitLab URLs with nested subgroups#1452truecallerabreham wants to merge 1 commit into
truecallerabreham wants to merge 1 commit into
Conversation
The gitlabURLRegex only allowed two path segments (owner/repo), rejecting valid GitLab URLs with subgroups like: https://gitlab.com/myorg/team/subgroup/my-mcp-server This is a standard GitLab feature used in GitLab Enterprise. Changes: - Updated regex to allow any number of path segments - Added unit tests for subgroup URLs (1, 2, and 3 levels deep) - Added comprehensive test cases for IsValidRepositoryURL Fixes modelcontextprotocol#1359
|
Thanks for adding subgroup coverage. One thing I think may fail in the new table test: the updated GitLab regex now allows a single path segment ( Maybe the pattern should still require at least two path segments, then allow extra subgroup segments after that, e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gitlabURLRegex in internal/validators/utils.go only allows two path segments (owner/repo), rejecting valid GitLab URLs with subgroups like:
https://gitlab.com/myorg/team/subgroup/my-mcp-serverGitLab subgroups are a standard feature used in GitLab Enterprise. The current regex prevents self-hosted registries from publishing servers whose source lives in a GitLab group hierarchy.
Changes
Test Plan
Related
Fixes #1359