fix(server): reject changed duplicate initialize#3078
Open
ychampion wants to merge 1 commit into
Open
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Keep duplicate initialize requests idempotent when the client sends the same parameters, but return INVALID_REQUEST if a stateful server is reinitialized with different parameters after negotiation.
ychampion
force-pushed
the
reject-duplicate-initialize
branch
from
fd8d08d to
394ed98
Compare
ychampion
changed the title
Author
|
Good catch. Updated in 394ed98:
Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initializerequests idempotent for already initialized stateful sessions.initializerequests so storedclient_paramsare not rewritten.Why
Fixes #2605. A later
initializeon the same session could overwriteServerSession.client_paramsafter negotiation. Existing connected-session fixtures also send an idempotent duplicateinitialize, so the rejection only applies when the duplicate request changes the original parameters.Validation
uv run pytest -n0 tests/server/test_session.py::test_duplicate_initialize_after_initialized_preserves_negotiated_params -q- passeduv run pytest -n0 tests/server/test_session.py tests/server/fastmcp/test_elicitation.py tests/server/fastmcp/test_url_elicitation.py tests/server/fastmcp/test_url_elicitation_error_throw.py tests/server/fastmcp/test_title.py tests/issues/test_141_resource_templates.py -q- passed, 34 testsuv run ruff format --check src/mcp/server/session.py tests/server/test_session.py- passeduv run ruff check src/mcp/server/session.py tests/server/test_session.py- passeduv run pyright src/mcp/server/session.py tests/server/test_session.py- passedgit diff --check- passedAI assistance: Codex.