Repository navigation
Prevent zero-sized letterbox resizes - #26
Merged
parkjinman98 merged 1 commit intoOct 2, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
cv2.resizeto raise an exception and enabling a low-severity denial-of-service when unhandled.Description
LetterBoxGeometry.from_shapessoresized_heightandresized_widthare at least1while keeping existing rounding/truncation behavior otherwise. This prevents zero-sized resize targets from reaching OpenCV.tests/test_yolox_damoyolo.pythat exercise extremely wide and extremely tall inputs through the packaged YOLOX and DAMO-YOLO preprocessing configurations to ensure the short axis remains nonzero forsize_rounding="floor".Testing
LD_LIBRARY_PATH=/tmp/fake-gl python -m pytest -q tests/test_yolox_damoyolo.py, resulting in94 passed(all tests in that file).LD_LIBRARY_PATH=/tmp/fake-gl python -m pytest -q tests/test_yolox_damoyolo.py -k 'floor_rounding', resulting in5 passedfor the focused cases.libGL.so.1so tests used a temporary no-op GL loader under/tmp/fake-gl;pre-commitwas not available in the execution environment.Codex Task