Repository navigation
RFC-0008: Accept an explicit source_type, validated against the source value - #44
Merged
Merged
Conversation
…fallback The CLI subcommands (register git/oci/zip) and SDK typed source classes always know the source type, but the wire format forbade sending it, so the server re-derived it from URL-shape heuristics that fail on common values (an HTTPS Git clone URL without a .git suffix, an archive URL without a .zip ending). Registration, version-creation, and import requests now accept an optional source_type for external pointers; the server validates it against the source value and rejects contradictions, infers the type only when none is submitted, and rejects an external pointer it can neither validate nor infer instead of misclassifying it. mlflow and assembled remain flow-derived and are never client-supplied, preserving the server-controlled artifact-path behavior that motivated making the field server-set during review (PR mlflow#26, discussion_r3698026016). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jwm4
marked this pull request as ready for review
September 1, 2026 18:32
With source_type explicit, the .git suffix matters only to the inference fallback, never to fetching; make that contract explicit so validators do not re-require the suffix, and direct users pasting provider web URLs (/tree/ pages) to the clone URL + ref + subpath fields instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mprahl
reviewed
Sep 1, 2026
mprahl
approved these changes
Sep 1, 2026
6 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Amends RFC-0008 so registration, version-creation, and import requests may carry an optional explicit
source_type(git/oci/zip) for external source pointers. The server validates a submitted type against the source value and rejects contradictions; when no type is submitted, the existing inference rules apply unchanged. An external pointer that can neither be validated nor inferred is rejected with a clear error instead of being misclassified.mlflowandassembledremain flow-derived and are never client-suppliable.Why
The CLI subcommands (
mlflow skills register git/oci/zip) and the SDK's typed source classes (GitSource,OCISource,ZipSource) always know the source type explicitly, but the wire format forbade sending it, so the server re-derived it from URL-shape heuristics (.gitsuffix,git://,oci://,.zip). Those heuristics fail on common real-world values: an HTTPS Git clone URL without the.gitsuffix, or an archive URL without a.zippath ending. Discarding a discriminator the client already holds and then guessing it back is strictly worse than carrying it and validating it.The field became unsendable in #26 (see this thread) as part of a fix whose actual concern was server-controlled artifact paths for MLflow-stored content. That concern is fully preserved here:
mlflowcontent is still flow-derived, and the server still never fetches user-supplied URLs.Scope
Documentation-only amendment to the merged RFC (main doc summary plus the implementation-details field tables, field-inference rules, request models, SDK docstring, and CLI mapping), per the living-document approach for merged RFCs.
Authored by Bill Murdock with assistance from Claude Code.
🤖 Generated with Claude Code