Fix Mistral SUT model ID formatting - #1661
Open
kaulastudies wants to merge 1 commit into
Open
kaulastudies wants to merge 1 commit into
kaulastudies wants to merge 1 commit into
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Mistral SUT model ID formatting by separating ModelBench's canonical SUT identity from the model ID sent to Mistral's API.
Dynamic Mistral definitions keep the canonical ModelBench UID:
but
MistralSUTFactory.make_sut()now sends only the model component (<model>) to Mistral'smodel_info()lookup and toMistralAISut.This prevents native Mistral model IDs such as
mistral-medium-3from being rewritten tomistral/mistral-medium-3, which returns 404 from the Mistral API.Tests
The regression test verifies both sides explicitly:
foo/bar:mistralbarmodel_info()is called withbarValidation
git diff --check: passedCloses #1659