Repository navigation
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the clean-install check to Python 3.14 and declares Python 3.15 as not supported yet.
3.14to the matrix of.github/workflows/clean_install_tests.yml, so the check runs on 3.11, 3.12, 3.13 and 3.14.requires-python = ">=3.11,<3.15"inpyproject.tomlWhy not 3.15
Building the package on Python 3.15 fails:
[build-system]pinsgrpcio-tools==1.80.0, which has no cp315 wheel. The first release with a cp315 wheel is 1.84.0, but it requiresprotobuf>=7.35.1, while the project currently requiresprotobuf>=6.31.1,<8. The comment inpyproject.tomlsays the protobuf lower bound has to stay in sync with the gencode thatgrpcio-toolsemits, so moving to 1.84+ would probably raise the runtime minimum for everyone.