Skip to content

Removed unused C++ ETFeeder - #268

Open
razvcris wants to merge 1 commit into
mlcommons:mainfrom
Keysight:refactor/issue-229-remove-etfeeder
Open

razvcris wants to merge 1 commit into
mlcommons:mainfrom
Keysight:refactor/issue-229-remove-etfeeder

Conversation

@razvcris

@razvcris razvcris commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Removes the C++ ETFeeder (src/feeder, tests/feeder) and everything that only existed to support it.

Why

Changes

  • Removed src/feeder, tests/feeder, and tests/data/feeder_tests_trace.tar.gz
  • Removed the C++ dependencies only the feeder used: protoio.cc/.hh and json.hpp from src/third_party/utils
  • Removed workflows feeder_tests.yml and cpp_lint.yml, plus .clang-format
  • Removed the c-cpp job and manual build step from codeql.yml (Python analysis unchanged)
  • Removed the ETFeeder section from USER_GUIDE.md

Test plan

  • Ran the Python test suite: python -m pytest tests/ - all tests pass
  • Searched for leftover references: grep -rIi "feeder\|protoio\|json.hpp\|clang" - no matches

Closes #229, #228

@razvcris razvcris self-assigned this Nov 12, 2026
@github-actions

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@razvcris razvcris linked an issue Nov 12, 2026 that may be closed by this pull request
@HanjiangWu313
HanjiangWu313 self-requested a review November 12, 2026 16:53
@danmih-ixia

Copy link
Copy Markdown
Contributor

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C++ feeder Single shared build script for the C++ feeder

3 participants