Repository navigation
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
HanjiangWu313
self-requested a review
November 12, 2026 16:53
HanjiangWu313
approved these changes
Nov 12, 2026
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the C++ ETFeeder (
src/feeder,tests/feeder) and everything that only existed to support it.Why
src/feedercopy here was only an example for downstream integrations.Changes
src/feeder,tests/feeder, andtests/data/feeder_tests_trace.tar.gzprotoio.cc/.hhandjson.hppfromsrc/third_party/utilsfeeder_tests.ymlandcpp_lint.yml, plus.clang-formatc-cppjob and manual build step fromcodeql.yml(Python analysis unchanged)USER_GUIDE.mdTest plan
python -m pytest tests/- all tests passgrep -rIi "feeder\|protoio\|json.hpp\|clang"- no matchesCloses #229, #228