Skip to content

Internalized et_replay and slimmed its content - #257

Open
mihncalo wants to merge 1 commit into
mlcommons:mainfrom
Keysight:build/issue-237-et-replay-installation
Open

mihncalo wants to merge 1 commit into
mlcommons:mainfrom
Keysight:build/issue-237-et-replay-installation

Conversation

@mihncalo

@mihncalo mihncalo commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Internalized et_replay from PARAM instead of adding git as a git dependency. It's no longer necessary to install PARAM separately, as the required code sits inside the chakra repo, thus removing the dependency.

Copied et_replay/ from PARAM into src/third_party/

__init__.py
execution_trace.py
utils.py
LICENSE

Removed unused or unncecessary functions from the execution_trace.py. Kept Node, NodeType, TensorNode, _CommArgs, ExecutionTrace and its schema-specific node constructors, LABEL_MARKERS, the process and thread annotation constants, and remove_dataloader_ops.
Changed import paths in the rest of the src/ files.
Updated pyproject.toml to incorporate the changes.
Removed PARAM from the workflows.

Test Plan

Created a fresh environment by runningpip install ..
Installed dev dependencies by running pip install -r requirements-dev.txt.
Ran the tests by running python -m pytest -vv tests. All 117 tests passed.
Used a sample input to test chakra_trace_link and chakra_converter. They run without issue and create byte-identical outputs as the current main.
Ruff checks passed without issues.

Additional Notes

There is still a lot that could be trimmed from the et_replay/ code, functions and attributes that we do not currently use. I intentionally decided against going any further for now to recreate exactly the behavior before these changes ( when PARAM was installed separately ). Further enhancements could be addressed in following issues.

Closes #237

@mihncalo
mihncalo requested a review from theodorbadea November 9, 2026 07:48
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@theodorbadea theodorbadea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please start from looking into the converter parser because most probably that can be reused and extended so that it also works for the linker. Also, it probably would be for the best to reimplement only the logic that is used from execution_trace.py rather than copying the entire file with a lot of extra stuff.

@theodorbadea
theodorbadea force-pushed the build/issue-237-et-replay-installation branch from db3ef91 to 9e047a8 Compare November 12, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle et_replay installation

2 participants