Repository navigation
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
theodorbadea
requested changes
Nov 9, 2026
theodorbadea
left a comment
Contributor
There was a problem hiding this comment.
Please start from looking into the converter parser because most probably that can be reused and extended so that it also works for the linker. Also, it probably would be for the best to reimplement only the logic that is used from execution_trace.py rather than copying the entire file with a lot of extra stuff.
theodorbadea
force-pushed
the
build/issue-237-et-replay-installation
branch
from
November 12, 2026 08:05
db3ef91 to
9e047a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Internalized et_replay from PARAM instead of adding git as a git dependency. It's no longer necessary to install PARAM separately, as the required code sits inside the chakra repo, thus removing the dependency.
Copied et_replay/ from PARAM into src/third_party/
Removed unused or unncecessary functions from the
execution_trace.py. KeptNode,NodeType,TensorNode,_CommArgs,ExecutionTraceand its schema-specific node constructors,LABEL_MARKERS, the process and thread annotation constants, andremove_dataloader_ops.Changed import paths in the rest of the src/ files.
Updated pyproject.toml to incorporate the changes.
Removed PARAM from the workflows.
Test Plan
Created a fresh environment by running
pip install ..Installed dev dependencies by running
pip install -r requirements-dev.txt.Ran the tests by running
python -m pytest -vv tests. All 117 tests passed.Used a sample input to test
chakra_trace_linkandchakra_converter. They run without issue and create byte-identical outputs as the current main.Ruff checks passed without issues.
Additional Notes
There is still a lot that could be trimmed from the et_replay/ code, functions and attributes that we do not currently use. I intentionally decided against going any further for now to recreate exactly the behavior before these changes ( when PARAM was installed separately ). Further enhancements could be addressed in following issues.
Closes #237