Configure S3 profile credentials in Witan - #357
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Named S3 merge endpoints can receive the wrong profile, and the new environment selectors are not hermetically cleared.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds AWS profile-based authentication for Witan S3 graph stores.
Changes:
- Adds global, per-target, and environment S3 settings.
- Exports AWS CLI credentials to omnigraph subprocesses.
- Updates tests, documentation, dependency floors, and release metadata.
File summaries
| File | Description |
|---|---|
uv.lock |
Locks witan-core 0.37.0. |
packages/witan-core/witan_core/omnigraph.py |
Resolves and forwards AWS credentials. |
packages/witan-core/tests/test_omnigraph.py |
Tests credential export behavior. |
packages/witan-core/pyproject.toml |
Bumps witan-core to 0.37.0. |
packages/witan-core/CHANGELOG.md |
Documents the new API. |
mcp/servers/witan/witan/server.py |
Propagates S3 settings to server clients. |
mcp/servers/witan/witan/context.py |
Supports S3-authenticated context reads. |
mcp/servers/witan/witan/config.py |
Loads S3 profile and region settings. |
mcp/servers/witan/witan/cli/maintenance.py |
Propagates settings to maintenance clients. |
mcp/servers/witan/witan/cli/hooks.py |
Propagates settings during context injection. |
mcp/servers/witan/tests/test_config.py |
Tests configuration precedence. |
mcp/servers/witan/tests/test_actor_client.py |
Updates actor-client test doubles. |
mcp/servers/witan/README.md |
Documents S3 profile configuration. |
mcp/servers/witan/pyproject.toml |
Raises the witan-core dependency floor. |
mcp/servers/witan/CHANGELOG.md |
Records the Witan feature. |
Review details
- Files reviewed: 16/17 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
blarghmatey
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
N/A
Description (What does it do?)
s3_profile/s3_regionsettings, with environment overrides.Implementation details
aws configure export-credentials --format processinstead of persisting credentials in Witan's configuration.witan-coreto 0.37.0 and raises Witan's dependency floor.How can this be tested?
s3_profileand optionals3_region, then run a read-only Witan command without the wrapper script.just test-all(2,777 passed, 4 skipped)just check-versionsjust check-core-floorAdditional Context
The repository-wide prek run remains blocked by pre-existing unrelated shebang-mode and shellcheck failures in
skills/process/renovate-security-triage/andskills/process/screenshot-pr/; every hook passed for this PR's changed files.