Repository navigation
Split non-.NET implementations into PdfLibrarys repositories - #214
Conversation
Preserve table geometry, merges, styles, registered and installed font metrics, and package images. Keep unsupported pagination and metafiles on the existing text path. TestIssue93 improves from 0.3331 to 0.9757 with all 27 unrelated issue DOCX outputs byte-identical. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bound border drawing, preserve font emphasis and alias glyph maps, honor Korean font selection and document grid types, correct cell borders and image targets, and retain legacy behavior for unsupported layouts and missing host fonts. Add focused regression tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve each language's Git history in PdfLibrarys/minipdf-go, minipdf-java, minipdf-node, minipdf-python, and minipdf-rs. Migrate CI/release workflows, fixture dependencies, repository metadata, and pinned Rust bindings before removing the original language trees. Retain .NET source, tests, demo, API, and shared benchmark tooling. Update contribution guidance, issue templates, and all translated READMEs to link independent implementations. Validation: all five standalone CI matrices pass; .NET solution builds and all 469 corpus-enabled tests pass; 36 reviewer automation tests pass; .NET Invoice visual score 0.9832. Java full 28-case DOCX comparison preserves page counts with no visual decrease beyond 0.002; approved issue91 regression score improves from 0.9600 to 0.9711. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Important Review skippedToo many files! This PR contains 158 files, which is 8 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
|
There was a problem hiding this comment.
🔵 Needs a closer look
The benchmark guide still references deleted scripts, leaving Quick Start commands broken; it should use the surviving .NET entry point and link to the independent language repositories.
No open issues 🎉
What changed in this PR
This PR separates the non-.NET implementations into independent PdfLibrarys repositories while retaining the .NET library, API, web demo, tests, and shared visual evaluation tooling. No .NET renderer or API source is changed.
Changes:
- Remove migrated language source, tests, packaging files, and release workflows.
- Remove obsolete non-.NET build and benchmark entry points.
- Scope contribution guidance, security support, and issue templates to .NET.
| File | Description |
|---|---|
| SECURITY.md | Limits security support here to .NET. |
| scripts/Run-Rust-VisualBenchmark.ps1 | Removes Rust benchmark wrapper. |
| scripts/Run-Rust-Benchmark.ps1 | Removes Rust benchmark entry point. |
| scripts/Run-Rust-Benchmark-Matrix.ps1 | Removes Rust benchmark matrix runner. |
| scripts/Run-Python-VisualBenchmark.ps1 | Removes Python benchmark wrapper. |
| scripts/Run-Node-VisualBenchmark.ps1 | Removes Node.js benchmark wrapper. |
| scripts/Run-Java-VisualBenchmark.ps1 | Removes Java benchmark wrapper. |
| scripts/Run-Go-VisualBenchmark.ps1 | Removes Go benchmark wrapper. |
| scripts/Run-All-Language-VisualBenchmarks.ps1 | Removes cross-language benchmark orchestration. |
| scripts/Invoke-NpmStageRelease.ps1 | Removes npm release approval helper. |
| scripts/Build-Python-Native.ps1 | Removes Python native build helper. |
| ROADMAP.md | Scopes implementation planning to .NET. |
| minipdf-rs/README.md | Removes migrated Rust documentation. |
| minipdf-rs/crates/minipdf/src/office.rs | Removes Rust format detection. |
| minipdf-rs/crates/minipdf/Cargo.toml | Removes Rust library manifest. |
| minipdf-rs/crates/minipdf-cli/Cargo.toml | Removes Rust CLI manifest. |
| minipdf-rs/Cargo.toml | Removes Rust workspace manifest. |
| minipdf-python/tests/test_options.py | Removes migrated Python option tests. |
| minipdf-python/tests/test_docx.py | Removes migrated Python DOCX tests. |
| minipdf-python/tests/test_cli.py | Removes migrated Python CLI tests. |
| minipdf-python/tests/test_api.py | Removes migrated Python API tests. |
| minipdf-python/tests/helpers.py | Removes Python fixture helpers. |
| minipdf-python/src/minipdf/xlsx.py | Removes Python XLSX renderer. |
| minipdf-python/src/minipdf/pptx.py | Removes Python PPTX renderer. |
| minipdf-python/src/minipdf/pdf.py | Removes Python PDF writer. |
| minipdf-python/src/minipdf/options.py | Removes Python conversion options. |
| minipdf-python/src/minipdf/office.py | Removes Python Office package handling. |
| minipdf-python/src/minipdf/errors.py | Removes Python exception definitions. |
| minipdf-python/src/minipdf/docx.py | Removes Python DOCX renderer. |
| minipdf-python/src/minipdf/cli.py | Removes Python CLI implementation. |
| minipdf-python/src/minipdf/api.py | Removes Python conversion API. |
| minipdf-python/src/minipdf/_native.pyi | Removes Python native type stubs. |
| minipdf-python/src/minipdf/__main__.py | Removes Python module entry point. |
| minipdf-python/src/minipdf/__init__.py | Removes Python package exports. |
| minipdf-python/README.md | Removes migrated Python documentation. |
| minipdf-python/pyproject.toml | Removes Python packaging configuration. |
| minipdf-python/native/src/lib.rs | Removes Python Rust bindings. |
| minipdf-python/native/Cargo.toml | Removes Python native manifest. |
| minipdf-node/test/index.test.js | Removes migrated Node.js tests. |
| minipdf-node/src/lib.rs | Removes Node.js Rust bindings. |
| minipdf-node/scripts/prepare-release.js | Removes npm package preparation. |
| minipdf-node/scripts/postprocess-loader.js | Removes native loader postprocessing. |
| minipdf-node/README.md | Removes migrated Node.js documentation. |
| minipdf-node/package.json | Removes Node.js package manifest. |
| minipdf-node/package-lock.json | Removes Node.js dependency lockfile. |
| minipdf-node/lib/index.js | Removes Node.js public wrapper. |
| minipdf-node/lib/index.d.ts | Removes Node.js public type declarations. |
| minipdf-node/index.d.ts | Removes generated native declarations. |
| minipdf-node/Cargo.toml | Removes Node.js native manifest. |
| minipdf-node/build.rs | Removes Node.js native build setup. |
| minipdf-java/README.md | Removes migrated Java documentation. |
| minipdf-java/pom.xml | Removes Java parent build configuration. |
| minipdf-java/minipdf/src/main/java/io/github/minisoftware/minipdf/RegisteredFont.java | Removes Java font value type. |
| minipdf-java/minipdf/src/main/java/io/github/minisoftware/minipdf/PdfPage.java | Removes Java PDF page API. |
| minipdf-java/minipdf/src/main/java/io/github/minisoftware/minipdf/PdfColor.java | Removes Java PDF color type. |
| minipdf-java/minipdf/src/main/java/io/github/minisoftware/minipdf/PageSize.java | Removes Java page-size type. |
| minipdf-java/minipdf/src/main/java/io/github/minisoftware/minipdf/OfficeFormat.java | Removes Java format enumeration. |
| minipdf-java/minipdf/src/main/java/io/github/minisoftware/minipdf/MiniPdfException.java | Removes Java exception type. |
| minipdf-java/minipdf/src/main/java/io/github/minisoftware/minipdf/MiniPdf.java | Removes Java public conversion API. |
| minipdf-java/minipdf/src/main/java/io/github/minisoftware/minipdf/internal/xlsx/XlsxConverter.java | Removes Java XLSX converter. |
| minipdf-java/minipdf/src/main/java/io/github/minisoftware/minipdf/internal/SecureXml.java | Removes Java secure XML helper. |
| minipdf-java/minipdf/src/main/java/io/github/minisoftware/minipdf/internal/OoxmlPackage.java | Removes Java Office package handling. |
| minipdf-java/minipdf/src/main/java/io/github/minisoftware/minipdf/internal/OfficePackageDetector.java | Removes Java format detection. |
| minipdf-java/minipdf/src/main/java/io/github/minisoftware/minipdf/internal/FontEmbeddingPolicy.java | Removes Java font embedding policy. |
| minipdf-java/minipdf/src/main/java/io/github/minisoftware/minipdf/internal/docx/DocxConverter.java | Removes Java DOCX converter. |
| minipdf-java/minipdf/src/main/java/io/github/minisoftware/minipdf/ConversionOptions.java | Removes Java conversion options. |
| minipdf-java/minipdf/pom.xml | Removes Java library build configuration. |
| minipdf-java/minipdf-tests/src/test/java/io/github/minisoftware/minipdf/PageSizeTest.java | Removes migrated Java page-size tests. |
| minipdf-java/minipdf-tests/src/test/java/io/github/minisoftware/minipdf/OoxmlSecurityTest.java | Removes migrated Java security tests. |
| minipdf-java/minipdf-tests/src/test/java/io/github/minisoftware/minipdf/OfficeFormatDetectionTest.java | Removes migrated Java format tests. |
| minipdf-java/minipdf-tests/src/test/java/io/github/minisoftware/minipdf/internal/xlsx/PoiXlsxRendererTest.java | Removes migrated Java XLSX tests. |
| minipdf-java/minipdf-tests/src/test/java/io/github/minisoftware/minipdf/internal/FontEmbeddingPolicyTest.java | Removes Java font policy tests. |
| minipdf-java/minipdf-tests/src/test/java/io/github/minisoftware/minipdf/FontRegistrationTest.java | Removes Java font registration tests. |
| minipdf-java/minipdf-tests/src/test/java/io/github/minisoftware/minipdf/cli/MiniPdfCommandTest.java | Removes migrated Java CLI tests. |
| minipdf-java/minipdf-tests/pom.xml | Removes Java test build configuration. |
| minipdf-java/minipdf-cli/pom.xml | Removes Java CLI packaging configuration. |
| minipdf-java/.mvn/wrapper/maven-wrapper.properties | Removes Java Maven wrapper configuration. |
| minipdf-go/xlsx_picture.go | Removes Go spreadsheet image handling. |
| minipdf-go/xlsx_number.go | Removes Go spreadsheet number formatting. |
| minipdf-go/xlsx_footer.go | Removes Go spreadsheet footer rendering. |
| minipdf-go/xlsx_font.go | Removes Go spreadsheet font handling. |
| minipdf-go/xlsx_color.go | Removes Go spreadsheet color handling. |
| minipdf-go/xlsx_color_test.go | Removes migrated Go color tests. |
| minipdf-go/pptx.go | Removes Go PPTX converter. |
| minipdf-go/pdf_test.go | Removes migrated Go PDF tests. |
| minipdf-go/pdf_image.go | Removes Go PDF image encoding. |
| minipdf-go/minipdf_test.go | Removes migrated Go API tests. |
| minipdf-go/go.sum | Removes Go dependency checksums. |
| minipdf-go/go.mod | Removes Go module manifest. |
| minipdf-go/docx.go | Removes Go DOCX converter. |
| minipdf-go/cmd/minipdf/main_test.go | Removes migrated Go CLI tests. |
| MAINTAINERS.md | Scopes maintainer responsibilities to .NET. |
| CONTRIBUTING.md | Updates setup and validation guidance for .NET. |
| .gitignore | Removes migrated implementation-specific exclusions. |
| .github/workflows/rust-ecosystem-release.yml | Removes coordinated Rust ecosystem releases. |
| .github/workflows/python-ci.yml | Removes Python CI workflow. |
| .github/workflows/pypi-publish.yml | Removes PyPI publishing workflow. |
| .github/workflows/node-ci.yml | Removes Node.js CI workflow. |
| .github/workflows/java-publish.yml | Removes Maven Central publishing workflow. |
| .github/workflows/java-ci.yml | Removes Java CI workflow. |
| .github/workflows/go-release.yml | Removes Go release workflow. |
| .github/workflows/go-ci.yml | Removes Go CI workflow. |
| .github/workflows/crates-publish.yml | Removes crates.io publishing workflow. |
| .github/PULL_REQUEST_TEMPLATE.md | Limits validation checklist to .NET. |
| .github/ISSUE_TEMPLATE/question.yml | Limits implementation selection to .NET. |
| .github/ISSUE_TEMPLATE/feature_request.yml | Limits feature targets to .NET. |
| .github/ISSUE_TEMPLATE/documentation.yml | Removes Rust and shared-language selections. |
| .github/ISSUE_TEMPLATE/conversion_quality.yml | Limits conversion reports to .NET. |
| .github/ISSUE_TEMPLATE/bug_report.yml | Limits implementation selection to .NET. |
| .claude/skills/minipdf-contribution/SKILL.md | Scopes contribution instructions to .NET benchmarks. |
Review effort: Balanced
Summary
Move each non-.NET implementation into an independent public repository, preserving its relevant Git history:
All five repositories have independently passing CI, migrated release workflows, repository metadata, licenses, and required test fixtures. Node.js and Python fetch the Rust engine through an immutable Git revision rather than a sibling checkout. The Go module now uses
github.com/PdfLibrarys/minipdf-go, with rootv<version>release tags; existing pinned historical versions remain in the original Git history.Retain the .NET implementation, API, web demo, tests, and shared visual evaluation tooling here. Remove the migrated language trees and obsolete workflows, update implementation links in every translated README, and scope contribution guidance, issue forms, and benchmark entry points to .NET. The two approved Go DOCX commits are included in the preserved Go history before removal. No .NET renderer or API source is changed.
New repository publishing credentials and registry trusted-publisher bindings must be configured before future package releases; no secrets were copied or published. Existing issues, pull requests, and release records were not transferred or deleted. Local working branches, including unmerged local .NET work, remain untouched.
The maintainer approved completing this migration through a PR after GitHub rejected a direct default-branch push. Repository protection rules were not modified.
Validation
Commands below passed in the corresponding repository roots unless noted:
dotnet build MiniPdf.sln --configuration Release— passed, zero errors; pre-existing warnings remain.dotnet test tests\MiniPdf.Tests\MiniPdf.Tests.csproj --configuration Release --no-build— passed, 469 tests, zero failures/skips after generating the classic XLSX corpus.node --test .github\tests\auto-reviewers.test.cjs .github\tests\review-approval-policy.test.cjs— passed, 36 tests.mvn -B -ntp -f tests\MiniPdf.Benchmark\pdfbox\pom.xml package— passed..\scripts\Run-DotNet-VisualBenchmark.ps1 -Suite issue -Format docx -Filter Invoice -SkipReference -SkipBuild -MinimumScore 0.95— passed, score 0.9832.gofmt -l .— empty;go vet ./...,go test ./...— passed; CLI build also passed.cargo fmt --check,cargo clippy --workspace --all-targets --locked -- -D warnings,cargo test --workspace --locked— passed, 115 tests;cargo package -p minipdf --locked --allow-dirty— passed before the migration commit; remote CI packages the clean committed tree.npm ci --ignore-scripts,cargo check,cargo fmt --check,cargo clippy --all-targets --locked -- -D warnings,npm run build,npm test,npm pack --dry-run --ignore-scripts— passed, eight tests.python -m pip wheel . --no-deps --no-build-isolation --wheel-dir dist,python -m pytest tests -q,python -m ruff check src tests,python -m ruff format --check src tests,python -m mypy src tests --python-executable <isolated-venv-python>,python -m maturin sdist --out dist,python -m twine check dist\*— passed, 24 tests; installed-wheel smoke verified native-engine loading and DOCX conversion. Existing local developer tooling was used read-only after dependency-download failures; standard clean installs/builds pass in all six remote CI environments..\mvnw.cmd -B -ntp verify— passed, 84 tests, zero failures/skips locally. The approved pre-existing Windows DOCX regression was fixed in the new Java repository, with a regression assertion for the actual justified-line right edge.-Suite issue -Format docx -SkipCandidate -SkipBuild -SkipReference -MinimumScore 0and separate candidate/report directories. All 28 conversions and comparisons completed; no page-count changes or visual decreases greater than 0.002. Mean overall score 0.832639 → 0.833150; TestIssue91 0.9600 → 0.9711, visual average 0.9392 → 0.9553, three pages retained. All 56 candidate PDFs passed strict parsing and content-stream decoding; the existing benchmark structure checker incorrectly flags PDFBox cross-reference streams as requiring traditionalxreftables.Passing independent CI evidence:
Font-dependent Java tests skip on CI hosts without the required licensed fonts; the local full suite ran without skips. Package publication was not attempted.
Original-repository PR CI passed: Ubuntu build/tests/NuGet pack, Windows font-dependent DOCX tests, reviewer-automation unit tests, and the security-review workflow. Local
dotnet pack src\MiniPdf\MiniPdf.csproj --no-build --configuration Release --output <validation-directory>also passed. The optional reviewer-invitation workflow fails because the existingCORE_REVIEWERS_TOKENsecret is missing; this is not a required merge check, and neither that workflow nor branch protections were disabled or bypassed.Checklist