Repository navigation
Split CSV rows only on the configured separator, not on tabs - #1046
Open
jayhemnani9910 wants to merge 1 commit into
Open
jayhemnani9910 wants to merge 1 commit into
jayhemnani9910 wants to merge 1 commit into
Conversation
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSV reader splits rows on a tab as well as on the configured separator. A comma-separated file with a tab inside a value then gets an extra field:
Query(path, useHeaderRow: true)throwsKeyNotFoundException: The given key '3' was not present in the dictionary., and without a header row the second line comes back with Qty in column D.SaveAswrites such a value without quotes, so MiniExcel can't read back its own CSV either.The split pattern in
CsvReader.Splitwas[\t{Seperator}].... It now uses only the configured separator, escaped. Files that use tabs as the separator needSeperator = '\t', as the docs and the existing tab test already do; before, they only worked by accident.Added
TabInsideValueIsNotASeparatorTest; it fails without the change. The CSV tests pass.Summary by CodeRabbit