Repository navigation
build-image: build-push-ecr's successor on docker/build-push-action - #84
Merged
Merged
Conversation
A composite for GitHub-hosted runners that owns only the ECR repository, the tag convention and the cache convention. Every build flag is a named input passed to docker/build-push-action, so the gha cache backend gets its token from the action itself and no shell assembles the build line. Each build imports from and exports to the Actions cache and <image>:buildcache in ECR. build-push-ecr stays for callers still on the in-cluster builder; the shared ECR policy moves here and the old directory links to it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mindsdb-devops
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New composite action for GitHub-hosted runners, replacing
build-push-ecrone repo at a time; the old action is deleted when its last caller moves.What it keeps from
build-push-ecr: the ECR repository creation with the shared policy, the four tags (<env>-<ref>,<env>-head-<pr sha>on pull requests,<env>,latest), and theBUILD_FOR_ENVIRONMENTandIMAGE_TAGbuild args.What changes:
docker/build-push-actionruns the build. Every flag is a named input (file,target,build-args,build-contexts,secrets,no-cache-filters,context);extra-build-argsandremote-builderare gone.scope=<module-name>and<image>:buildcachein ECR, bothmode=max. The gha backend's token stays insidebuild-push-action.digestoutput, for callers that read it from a metadata file today.build-image/;build-push-ecr/shared-ecr-policy.jsonis a symlink to it.Tested from mindsdb/scratchpad-controller#145, whose dev build checks out this branch.
🤖 Generated with Claude Code