Repository navigation
fix(release-pr): list only commits no release has shipped, and fit GitHub's body limit (ENG-4378) - #81
Merged
Conversation
…tHub's body limit (ENG-4378)
… tree alone (ENG-4378)
mindsdb-devops
approved these changes
Nov 17, 2026
mindsdb-devops
deleted the
fix/eng-4378-release-pr-unreleased-commits
branch
November 17, 2026 05:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User story
As a release-train owner opening Monday's release
I want every repository's release PR to open each week and list what it will ship
So that I can review a release without paging through months of work that already shipped
Why this matters
cowork's release PR stopped opening after its last release merged.
gh pr createrefused the body:Body is too long (maximum is 65536 characters). Every staging build re-ran the workflow and failed again. The list was wrong anyway: it showed 868 commits, and only 18 were unreleased.What happens today
The body lists
git log main..staging. A squash-merged release puts one new commit on main, so the staging commits it shipped never become ancestors of main, and the list keeps them forever. cowork's release titles grew 764, 805, 850, 868.What should happen
scripts/release_commits.pystarts the list at the head of the newest mergedstaging → mainPR. It lists the non-merge commits on staging that neither main nor that head contains. With merge-commit releases that equalsmain..staging. With no merged release, or a head staging no longer contains, it falls back tomain..staging; a failed lookup does the same with a warning. The title's count and the Contributors come from the same list. Every run writes the whole list to its step summary. A list over 60,000 characters is cut, and the body links that run's summary, since GitHub's compare view fails to render a range that long. The check step decides on the tree alone and no longer logs themain..stagingcount.Test plan
main..stagingrange.main..staging, as before.main..staging; the failed lookup is flagged.release-pr.yml, no change on staging lacks a listed commit. Squash-release lists drop to their unreleased commits (cowork 809 → 18), and merge-commit and no-release lists are unchanged.pytest tests/(308 passed, 15 skipped), actionlint andworkflow_graph.pypass; zizmor reports nothing new.