[ianardee]

Description

• Passing polling options in model parameters is not documented and should never be used.
• Fix data_schema and text_context not passed in hash mode.
• Split up the enqueue_and_get_result method.
• Misc fixes.

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Requires a change to the official Guide documentation.

[Copilot]

🟡 Changes recommended

Partial polling-option hashes override defaults with nil and break polling after submission, while the RBS signature incorrectly requires a cancellation token, invalidating existing three-argument calls.

2 open issues

• Preserve defaults for omitted polling settings · New
• Make the RBS cancellation-token parameter optional · New

What changed in this PR

This PR separates polling configuration from V2 product parameters in the Mindee Ruby SDK, intentionally removing the legacy way of passing polling options through product parameters.

Changes:

• Moves polling normalization and validation into PollingOptions and extracts the V2 polling loop.
• Updates parameter classes, type signatures, and tests to use separate polling options.
• Includes namespace cleanup, editor configuration updates, and a V1 PDF-processing call adjustment.

File	Description
spec/​v2/​product/​split/​split_integration.rb	Renames the split parameter variable.
spec/​v2/​product/​ocr/​ocr_integration.rb	Renames the OCR parameter variable.
spec/​v2/​product/​crop/​crop_integration.rb	Renames the crop parameter variable.
spec/​v2/​product/​classification/​classification_integration.rb	Renames the classification parameter variable.
spec/​v2/​file_operations/​split_operation_integration.rb	Renames extraction parameters.
spec/​v2/​file_operations/​crop_operation_integration.rb	Renames extraction parameters.
spec/​v2/​client_v2_spec.rb	Passes polling options separately in the cancellation test.
spec/​v2/​client_v2_integration.rb	Uses parameter hashes and removes the legacy polling test.
sig/​mindee/​v2/​product/​split/​params/​split_parameters.rbs	Removes the polling constructor option.
sig/​mindee/​v2/​product/​ocr/​params/​ocr_parameters.rbs	Removes the polling constructor option.
sig/​mindee/​v2/​product/​extraction/​params/​extraction_parameters.rbs	Removes the polling constructor option.
sig/​mindee/​v2/​product/​crop/​params/​crop_parameters.rbs	Removes the polling constructor option.
sig/​mindee/​v2/​product/​classification/​params/​classification_parameters.rbs	Removes the polling constructor option.
sig/​mindee/​v2/​client.rbs	Updates client and private polling signatures.
sig/​mindee/​v2/​client_options/​base_product_parameters.rbs	Removes polling-related declarations.
sig/​mindee/​input/​polling_options.rbs	Declares hash loading and validation.
lib/​mindee/​v2/​product/​split/​params/​split_parameters.rb	Removes the polling constructor option.
lib/​mindee/​v2/​product/​ocr/​params/​ocr_parameters.rb	Removes the polling constructor option.
lib/​mindee/​v2/​product/​extraction/​params/​extraction_parameters.rb	Removes polling options and forwards context/schema hash values.
lib/​mindee/​v2/​product/​crop/​params/​crop_parameters.rb	Removes the polling constructor option.
lib/​mindee/​v2/​product/​classification/​params/​classification_parameters.rb	Removes the polling constructor option.
lib/​mindee/​v2/​client.rb	Separates polling options and extracts the polling loop.
lib/​mindee/​v2/​client_options/​base_product_parameters.rb	Removes polling storage, normalization, and validation.
lib/​mindee/​v1/​client.rb	Calls apply_page_options and reformats method signatures.
lib/​mindee/​input/​polling_options.rb	Adds hash conversion and constructor validation.
lib/​mindee.rb	Reorganizes namespace declarations.
.editorconfig	Consolidates whitespace rules and extends Markdown matching.

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The signature incorrectly requires polling_options:, rejecting typed callers that omit the keyword even though the Ruby implementation supports that form with default settings.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Make polling_options optional to match the Ruby default

sig/​mindee/​input/​polling_options.rbs:11

This signature requires polling_options:, but the Ruby implementation defaults it to {}, so PollingOptions.from_hash without arguments is valid and returns the default settings. Typed callers using that supported form will be rejected. Mark the keyword optional to match the implementation.

2 resolved since last review

• Make the RBS cancellation-token parameter optional
• Preserve defaults for omitted polling settings

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Human assessment is needed because existing tests do not verify how custom polling settings affect delays and request counts, leaving the rework’s key behavior insufficiently validated.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The new polling validation tests never run in CI because polling_options.rb does not match the unit or integration spec filename patterns.

1 open issue

• Rename spec file so CI runs polling validation tests · New

_{Review effort: Max}

[Copilot]

🟡 Changes recommended

Critical polling errors can reject jobs completed on the final attempt and create remote jobs before validating options, leaving callers without a job ID.

3 open issues

• Validate polling options before enqueuing the job · New
• Inspect the final poll response before timing out · New
• Avoid sending extraction fields twice for hash requests · New

1 resolved since last review

• Rename spec file so CI runs polling validation tests

_{Review effort: Max}

[Copilot]

🟡 Changes recommended

The shipped RBS interface still declares enqueue_form_options, which MindeeApiV2 no longer implements.

1 open issue

• Remove the stale enqueue_form_options type declaration · New

3 resolved since last review

• Inspect the final poll response before timing out
• Validate polling options before enqueuing the job
• Avoid sending extraction fields twice for hash requests

_{Review effort: Max}

[Copilot]

🟡 Changes recommended

Regression tests are missing for polling-option normalization and custom settings during polling, and for preserving text_context and data_schema through ExtractionParameters.from_hash.

2 open issues

• Add polling options normalization and client configuration tests · New
• Test hash conversion of text_context and data_schema · New

1 resolved since last review

• Remove the stale enqueue_form_options type declaration

_{Review effort: Max}