Skip to content

🐛 fix file alias being sent as an invalid parameter#264

Merged
sebastianMindee merged 3 commits into
mainfrom
fix-file-alias
Jul 15, 2026
Merged

🐛 fix file alias being sent as an invalid parameter#264
sebastianMindee merged 3 commits into
mainfrom
fix-file-alias

Conversation

@sebastianMindee

Copy link
Copy Markdown
Collaborator

Description

  • fix typing oversight

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes how file aliases are sent to the Mindee V2 API by switching the multipart form field name to the expected alias, and aligns several RBS signatures with the actual polling_options nilability.

Changes:

  • Send the file alias using the alias multipart field instead of file_alias.
  • Update RBS method signatures to explicitly allow polling_options to be nil.
  • Add an integration expectation asserting the returned inference file alias.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
spec/v2/client_v2_integration.rb Adds an integration assertion for the returned file alias.
sig/mindee/v2/product/split/params/split_parameters/split_parameters.rbs Adjusts polling_options type to include nil.
sig/mindee/v2/product/ocr/params/ocr_parameters/ocr_parameters.rbs Adjusts polling_options type to include nil.
sig/mindee/v2/product/extraction/params/extraction_parameters.rbs Adjusts polling_options type to include nil.
sig/mindee/v2/product/crop/params/crop_parameters/crop_parameters.rbs Adjusts polling_options type to include nil.
sig/mindee/v2/product/classification/params/classification_parameters/classification_parameters.rbs Adjusts polling_options type to include nil.
sig/mindee/v2/client.rbs Updates polling-options-related param types to include nil.
sig/mindee/input/base_parameters.rbs Updates polling-options-related param types to include nil.
lib/mindee/v2/product/extraction/params/extraction_parameters.rb Updates YARD type reference for polling_options.
lib/mindee/v2/http/mindee_api_v2.rb Changes enqueue form field from file_alias to alias.
lib/mindee/input/base_parameters.rb Changes base form field from file_alias to alias.

Comment thread spec/v2/client_v2_integration.rb Outdated
Comment thread lib/mindee/v2/http/mindee_api_v2.rb
@sebastianMindee sebastianMindee merged commit 30d3150 into main Jul 15, 2026
33 checks passed
@sebastianMindee sebastianMindee deleted the fix-file-alias branch July 15, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants