🐛 fix file alias being sent as an invalid parameter#264
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes how file aliases are sent to the Mindee V2 API by switching the multipart form field name to the expected alias, and aligns several RBS signatures with the actual polling_options nilability.
Changes:
- Send the file alias using the
aliasmultipart field instead offile_alias. - Update RBS method signatures to explicitly allow
polling_optionsto benil. - Add an integration expectation asserting the returned inference file alias.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/v2/client_v2_integration.rb | Adds an integration assertion for the returned file alias. |
| sig/mindee/v2/product/split/params/split_parameters/split_parameters.rbs | Adjusts polling_options type to include nil. |
| sig/mindee/v2/product/ocr/params/ocr_parameters/ocr_parameters.rbs | Adjusts polling_options type to include nil. |
| sig/mindee/v2/product/extraction/params/extraction_parameters.rbs | Adjusts polling_options type to include nil. |
| sig/mindee/v2/product/crop/params/crop_parameters/crop_parameters.rbs | Adjusts polling_options type to include nil. |
| sig/mindee/v2/product/classification/params/classification_parameters/classification_parameters.rbs | Adjusts polling_options type to include nil. |
| sig/mindee/v2/client.rbs | Updates polling-options-related param types to include nil. |
| sig/mindee/input/base_parameters.rbs | Updates polling-options-related param types to include nil. |
| lib/mindee/v2/product/extraction/params/extraction_parameters.rb | Updates YARD type reference for polling_options. |
| lib/mindee/v2/http/mindee_api_v2.rb | Changes enqueue form field from file_alias to alias. |
| lib/mindee/input/base_parameters.rb | Changes base form field from file_alias to alias. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes