Skip to content

fix: recover legacy Copilot entries mislabeled as Claude or shell - #2

Merged
millwright-software merged 1 commit into
millwright-software:mainfrom
er0826-dex:fix/copilot-legacy-session-recovery
Oct 26, 2026
Merged

millwright-software merged 1 commit into
millwright-software:mainfrom
er0826-dex:fix/copilot-legacy-session-recovery

Conversation

@er0826-dex

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #1, based on the current upstream main. The original recovery fix was merged before this legacy-entry correction was pushed.

  • Recognize saved entries whose launch executable is Copilot even when their stored tool is Claude or shell, so they enter the correct conversation-recovery path.
  • Pin Copilot tool identity across storage reloads and invalidate stale detection caches. A Claude model banner inside Copilot must not reclassify it as Claude Code.
  • Share executable recognition with the CLI and cover legacy loading, persistence, model-name precedence, and cache invalidation with regression tests.

Validation

  • Targeted Copilot session, tmux, and UI race tests pass.
  • Changed-code lint passes with zero issues.
  • The patch previously passed full affected-package race tests, build, vet, and isolated real-tmux recovery scenarios using genuinely mislabeled legacy entries.
  • The resulting source tree matches the locally installed follow-up version. The user reports their sessions are now working.

This PR contains only the seven-file follow-up patch, not the changes already merged in #1. Machine-specific conversation mappings and backups remain local and are not included.

Normalize saved copilot commands mislabeled as Claude or shell. Keep runtime model-banner detection from changing the owning CLI and bypassing conversation recovery.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@millwright-software
millwright-software merged commit 94add29 into millwright-software:main Oct 26, 2026
1 check passed
millwright-software added a commit that referenced this pull request Oct 26, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
millwright-software added a commit that referenced this pull request Nov 12, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants