Skip to content

Fix DS18S20 broadcast conversion wait #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
94xhn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix DS18S20 broadcast conversion wait #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions DallasTemperature.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,12 +318,15 @@ float DallasTemperature::getTempFByIndex(uint8_t index) {
}

void DallasTemperature::setResolution(uint8_t newResolution) {
bitResolution = constrain(newResolution, 9, 12);
newResolution = constrain(newResolution, 9, 12);
bitResolution = newResolution;
DeviceAddress deviceAddress;
_wire->reset_search();
for (uint8_t i = 0; i < devices; i++) {
if (_wire->search(deviceAddress) && validAddress(deviceAddress)) {
setResolution(deviceAddress, bitResolution, true);
setResolution(deviceAddress, newResolution, true);
// DS18S20 is fixed at 9-bit but needs the 12-bit conversion delay.
if (deviceAddress[0] == DS18S20MODEL) bitResolution = 12;
}
}
}
Expand Down Expand Up @@ -815,4 +818,4 @@ int16_t DallasTemperature::getUserDataByIndex(uint8_t deviceIndex) {
DeviceAddress deviceAddress;
getAddress(deviceAddress, deviceIndex);
return getUserData((uint8_t*)deviceAddress);
}
}