Fix #252: Add exact-output assertion for schedule create example normalization - #253
Fix #252: Add exact-output assertion for schedule create example normalization#253kaovilai wants to merge 1 commit into
Conversation
…igtools#252) Add a full string comparison to TestReplaceVeleroWithOADP_ScheduleCreateVerbFirst that verifies cmd.Example matches the complete expected normalized text after the verb-first "velero create schedule" is rewritten to "oc oadp schedule create". The existing checks for removal of "velero create schedule" and the occurrence count of "oc oadp schedule create NAME" are kept as complementary guards. The new assertion catches any drift in whitespace, ordering, or replacement logic and shows both expected and actual strings on failure. Fixes migtools#252 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe schedule-create normalization test now checks the complete expected output, including both normalized command lines, ordering, and whitespace. ChangesSchedule normalization test
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds exact-output assertion to
TestReplaceVeleroWithOADP_ScheduleCreateVerbFirstincmd/root_test.go.Fixes #252
Note
Proposed by chai-bot (redhat-chai-bot), opened as draft via Claude Code.
Summary by CodeRabbit