[Eduard Arbona (earbona23)]

Fixes #1070 (and the earlier #365, which was closed without a fix).

The bug

Sample 3 in docs/drives_samples.md was:

items = await client.drives.by_drive_id('DRIVE_ID').items.get()   # GET /drives/{id}/items

GET /drives/{id}/items is not an enumerable collection in Microsoft Graph — it
addresses driveItems by id and only answers $filter queries — so following the sample
returns exactly the error nine people reacted to:

The 'filter' query option must be provided.

The SDK and Graph are both behaving correctly; the sample documented a call that cannot
work. #365 reported this and was closed with no fix while the broken sample stayed in place.

The fix

Sample 3 now does what its title says — list all the items — by walking root with
delta and paging through odata_next_link:

page = await client.drives.by_drive_id('DRIVE_ID').items.by_drive_item_id('root').delta.get()
while page:
    if page.value:
        for item in page.value:
            print(item.id, item.name, item.size, item.folder, item.file)
    if not page.odata_next_link:
        break
    page = await client.drives.by_drive_id('DRIVE_ID').items.by_drive_item_id('root').delta.with_url(page.odata_next_link).get()

This also removes an overlap: as written, sample 3 duplicated sample 6 (which lists only the
top level via root/children). Now 3 is the recursive listing and 6 is the top-level one,
with a cross-reference between them so the distinction is explicit.

Verified against the generated SDK in this repo

• items.by_drive_item_id('root').delta — msgraph/generated/drives/item/items/item/delta/delta_request_builder.py
• .with_url() for paging — same file, line 65
• odata_next_link and value on the response — inherited from BaseDeltaFunctionResponse (msgraph/generated/models/base_delta_function_response.py:18)
• the snippet parses as valid Python

Docs-only, one file. I did not run it against a live drive (no tenant), so if a maintainer
runs it and sees anything off with the paging, tell me and I will adjust — but every symbol
it uses is confirmed present in the generated client.

[Eduard Arbona (earbona23)]

@microsoft-github-policy-service agree

[Eduard Arbona (earbona23)]

A first check-in on this one: it has had no reviewer assigned since I opened it on 2 September, and the request list is empty, so I think it fell through rather than being held back.

Still accurate today. On main, docs/drives_samples.md line 46 is unchanged:

items = await client.drives.by_drive_id('DRIVE_ID').items.get()

That is GET /drives/{id}/items, which is not an enumerable collection, so anyone following sample 3 still gets The 'filter' query option must be provided. — which is #1070, and #365 before it. The PR is one file, docs only, and GitHub reports it MERGEABLE; it is behind main, which for a markdown-only change costs nothing.

Gavin Barron (@gavinbarron), you have been merging non-generated PRs here recently — could you point this at whoever owns docs/, or review it yourself if that is quicker? @microsoftgraph/msgraph-devx-python-write is the code owner but was never asked.

Two honest caveats, unchanged from the description: I did not run the snippet against a live drive, so the shape is verified against the generated request builders in this repo rather than against a tenant; and if these docs are meant to be generated from somewhere upstream rather than edited here, say so and I will close this and file it there instead.