Skip to content

Generated models and request builders - #3161

Open
microsoft-graph-devx-bot[bot] wants to merge 1 commit into
mainfrom
kiota/v1.0/pipelinebuild/230403
Open

Generated models and request builders#3161
microsoft-graph-devx-bot[bot] wants to merge 1 commit into
mainfrom
kiota/v1.0/pipelinebuild/230403

Conversation

@microsoft-graph-devx-bot

@microsoft-graph-devx-bot microsoft-graph-devx-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

‼️Important‼️
Check for unexpected deletions or changes in this PR and ensure relevant CI checks are passing.

Note: This pull request was automatically created by Azure pipelines.

Microsoft Reviewers: Open in CodeFlow

Update generated files with build 230403
@microsoft-graph-devx-bot
microsoft-graph-devx-bot Bot requested a review from a team as a code owner August 4, 2026 22:48
Copilot AI lite review requested due to automatic review settings August 4, 2026 22:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@peombwa peombwa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. The IsManualApprovalEnabled/IsWaitlistEnabled removal flagged by the public API surface check is a false positive.

I verified both the OpenAPI spec and the generated code on this branch:

  • In openapi.yaml, isManualApprovalEnabled and isWaitlistEnabled moved from the virtualEventWebinarRegistrationConfiguration schema up to its base schema, virtualEventRegistrationConfiguration.
  • In the generated code, VirtualEventRegistrationConfiguration now declares both properties (with serialization for isManualApprovalEnabled/isWaitlistEnabled handled there), while VirtualEventWebinarRegistrationConfiguration (which still inherits from it) no longer redeclares them - its Serialize/GetFieldDeserializers just delegate to base.

Since VirtualEventWebinarRegistrationConfiguration still inherits from VirtualEventRegistrationConfiguration, existing consumer code calling webinarConfig.IsManualApprovalEnabled / .IsWaitlistEnabled continues to compile and behave identically - the properties are just inherited now instead of declared on the derived type. The JSON wire format is unchanged. No source or binary compatibility impact.

Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants