Skip to content

Fail E2E runs when cache cleanup is incomplete - #1264

Open
KayMKM wants to merge 1 commit into
mainfrom
yuesu/investigate-run-eval-timeout
Open

Fail E2E runs when cache cleanup is incomplete#1264
KayMKM wants to merge 1 commit into
mainfrom
yuesu/investigate-run-eval-timeout

Conversation

@KayMKM

@KayMKM KayMKM commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • verify that Hugging Face, WinML, and VAIP cache directories are actually removed
  • propagate cache cleanup failures to the E2E runner exit status
  • cover successful cleanup, unavailable VAIP cache, and persistent file locks

Validation

  • uv run --no-sync pytest tests/unit/eval/test_run_eval_script.py -q --basetemp temp/pytest_tmp/cache-cleanup-pr
  • uvx ruff check scripts/e2e_eval/run_eval.py tests/unit/eval/test_run_eval_script.py

@KayMKM
KayMKM requested a review from a team as a code owner July 31, 2026 06:30
safe_print(f" [cleanup] Removing cache: {cache_dir}")
try:
shutil.rmtree(cache_dir)
except FileNotFoundError:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants