Add EP and device targeting to optimize - #1256
Conversation
DingmaomaoBJTU
left a comment
DingmaomaoBJTU
left a comment
There was a problem hiding this comment.
Good feature — makes --check-optim target-aware so it can skip capabilities irrelevant to the target EP and run the ORT optimization session with the resolved provider. Well-tested.
DingmaomaoBJTU
left a comment
DingmaomaoBJTU
left a comment
There was a problem hiding this comment.
Second pass. Found an important merge interaction with PR #1257 in _iter_findings — see inline comment on analysis.py.
Also verified: default_kwargs.update(optimizer_kwargs) forwards ep_device to ALL pipes via build_config(**kwargs). Safe because other pipes accept **kwargs and ignore unknown keys. The provider verification after ORT session creation (graph.py) addresses my first-pass concern about silent EP fallback.
DingmaomaoBJTU
left a comment
DingmaomaoBJTU
left a comment
There was a problem hiding this comment.
LGTM. EP/device targeting is well-implemented with proper provider verification. The merge interaction with PR #1257 (EP constraint continue bypasses complete_probe) needs a one-line fix in whichever merges second — non-blocking for approval.
…_to_optimize # Conflicts: # src/winml/modelkit/commands/optimize.py # src/winml/modelkit/optim/analysis.py # tests/unit/commands/test_optimize_cli.py # tests/unit/optim/test_analysis.py
2 participants
Summary