fix(media-preview): support untitled audio documents - #336411
Open
Abhishek Tripathi (Abhi-05-git) wants to merge 1 commit into
Open
Abhishek Tripathi (Abhi-05-git) wants to merge 1 commit into
Abhishek Tripathi (Abhi-05-git) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes support for opening and previewing untitled audio documents in the Media Preview extension.
Previously,
AudioPreviewProviderdid not preserve the contents of untitled documents when VS Code created the custom document. As a result, the audio preview could not reliably access the in-memory data for an untitled audio document.This change updates the custom document lifecycle to carry the untitled document data through to the audio preview.
Changes
AudioPreviewDocumentextendingvscode.CustomDocument.untitledDocumentDatato preserve in-memory audio content.openCustomDocumentto receive and storeCustomDocumentOpenContext.untitledDocumentDatafrom the custom document intoAudioPreview.resolveCustomEditortyping to use the newAudioPreviewDocument.Technical Details
The implementation uses VS Code's
CustomDocumentOpenContext.untitledDocumentDatato retain the contents of untitled audio documents.This allows
AudioPreviewto receive the in-memoryUint8Arraydata directly instead of relying only on a URI, which is important for documents that have not been saved to disk.Validation
Related
This addresses the handling of untitled audio documents in the Media Preview extension.