Detect same-metadata customization edits in chat - #336402
Merged
Dmitriy Vasyura (dmitrivMS) merged 2 commits intoSep 16, 2026
Merged
Conversation
Check source content before reusing synced bundles, preserving existing content hashing, recovery, and unchanged-content write skipping. Cover same-size, same-mtime edits and cached-state behavior deterministically. Fixes microsoft/vscode-engineering#3814 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
September 16, 2026 11:09
View session
Dmitriy Vasyura (dmitrivMS)
changed the title
Dmitriy Vasyura (dmitrivMS)
added
vscode-build
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The correctness fix is well covered; remaining feedback is a non-blocking filesystem optimization.
Review tier: Balanced
Findings: 1
Open (1)
What changed in this PR
Fixes stale customization bundles when edits preserve file size and mtime.
Changes:
- Always hash source contents before cache reuse.
- Add deterministic text, binary, provenance, enablement, failure, and disposal tests.
- Preserve tree reuse when contents are unchanged.
| File | Description |
|---|---|
syncedCustomizationBundler.ts |
Removes unsafe metadata-only cache reuse. |
syncedCustomizationBundler.test.ts |
Adds regression and recovery coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Read validation already stats each source. Pass source URIs directly when collecting entries and retain metadata checks for directory traversal. Verify per-source stat counts on both initial bundles and rebundles. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
marked this pull request as ready for review
September 16, 2026 15:51
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
September 16, 2026 15:52
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
September 16, 2026 16:11
View session
Michael Lively (Yoyokrazy)
approved these changes
Sep 16, 2026
Dmitriy Vasyura (dmitrivMS)
deleted the
dmitrivMS/fix-synced-customization-nonce
branch
September 16, 2026 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode-engineering#3814.
Replaces #335190 with the same reviewed patch, submitted under my account.
Summary
Unchanged rebundles now reread and hash source files, using the existing 10-operation filesystem limiter.
Validation