Deny writes to macOS terminal sandbox config - #336378
Draft
azure-pipelines[bot] wants to merge 1 commit into
Draft
azure-pipelines[bot] wants to merge 1 commit into
azure-pipelines[bot] wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Add a macOS test asserting that checkFileAccess('write', [configPath]) denies the configuration path.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Prevents sandboxed macOS terminal commands from writing to their sandbox configuration file.
Changes:
- Adds the configuration path to macOS
denyWriterules. - Adds regression coverage for the serialized deny-write configuration.
- The test does not yet verify
checkFileAccessenforcement for the config path.
File summaries
| File | Summary |
|---|---|
src/vs/platform/sandbox/test/common/terminalSandboxEngine.test.ts |
Tests the macOS deny-write configuration. |
src/vs/platform/sandbox/common/terminalSandboxEngine.ts |
Denies writes to the generated macOS sandbox configuration. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+417
to
+423
| deepStrictEqual({ | ||
| configDenyWrite: config.filesystem.denyWrite.includes(configPath), | ||
| tempDirAllowWrite: config.filesystem.allowWrite.includes(tempDirPath), | ||
| }, { | ||
| configDenyWrite: true, | ||
| tempDirAllowWrite: true, | ||
| }); |
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://portal.microsofticm.com/imp/v3/incidents/details/31000000679378/home