agentHost: bump Copilot SDK to 1.0.14 preview - #336360
Draft
roblourens wants to merge 5 commits into
Draft
roblourens wants to merge 5 commits into
roblourens wants to merge 5 commits into
Conversation
The bumped @github/copilot runtime now names the OTel root span
`invoke_agent {gen_ai.agent.name}` per GenAI semconv (verified in
copilot-agent-runtime session_tracker.rs), so the exact `"name":"invoke_agent"`
substring match no longer holds; match by prefix. The SDK span is also exported
via the runtime's AsyncBatchSpanProcessor (~5s scheduled delay), so widen the
poll budget past that cadence to avoid racing the batched export.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restore the staged SDK after product packaging before target-native files are materialized, and fail if the SDK entrypoint is absent. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Refresh the SDK bump branch before opening the pull request. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The OTel assertion still accepts the old span name and therefore does not validate the renamed SDK span.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced
Findings: 1
Open (2)
What changed in this PR
Updates the Agent Host Copilot runtime/SDK and packaging support.
Changes:
- Bumps Copilot dependencies and transitive native packages.
- Updates OTel span timing/name expectations.
- Preserves and restores the packaged Copilot SDK entrypoint.
| File | Description |
|---|---|
package.json |
Bumps Copilot dependencies. |
package-lock.json |
Locks updated dependencies. |
remote/package.json |
Bumps remote dependencies. |
remote/package-lock.json |
Locks remote dependencies. |
build/.moduleignore |
Preserves the SDK entrypoint. |
build/lib/copilot.ts |
Restores missing staged SDK files. |
build/lib/test/copilot.test.ts |
Tests SDK restoration. |
build/gulpfile.vscode.ts |
Supplies the desktop staged SDK. |
build/gulpfile.reh.ts |
Supplies the remote staged SDK. |
src/vs/platform/agentHost/test/node/e2e/providers/copilotOtelAgentHostE2E.integrationTest.ts |
Updates OTel expectations and polling. |
Files not reviewed (1)
- remote/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Base:
|
roblourens
marked this pull request as draft
September 16, 2026 04:41
Tighten OTel span matching, remove cross-chat ordering from the retained-subagent snapshot, and approve the SDK's updated koffi dependency. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@github/copilot-sdkto1.0.14-preview.1and the Agent Host Copilot runtime to1.0.84-9.@github/copilot/sdk/index.jsin packaged built-in Copilot extensions, restoring the staged SDK for desktop and remote builds when needed.Validation
npm cinpm run compile(0 errors)npm run typecheck --prefix buildnode --test build\lib\test\copilot.test.ts(22 passing)Full
npm run hygieneis currently blocked in this Windows worktree by a pre-existingC:\C:\...path construction failure; the changed files passed the pre-commit hygiene hook.(Written by Copilot)