Add expassigned tag to settings editor to show which settings are actively affected by an exptreatment - #336350
Draft
SteVen Batten (sbatten) wants to merge 2 commits into
Draft
SteVen Batten (sbatten) wants to merge 2 commits into
SteVen Batten (sbatten) wants to merge 2 commits into
Conversation
Copilot started reviewing on behalf of
SteVen Batten (sbatten)
September 16, 2026 00:32
View session
SteVen Batten (sbatten)
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The assignment refresh bypasses existing focus-preserving rendering and can drop keyboard focus.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds @tag:expassigned filtering to show settings with active ExP assignments.
Changes:
- Tracks ExP assignment state independently from treatment values.
- Adds Settings editor filtering, menu integration, and live refresh.
- Adds assignment, configuration, filtering, and accessibility tests.
| File | Description |
|---|---|
src/vs/workbench/services/configuration/test/common/experimentalSettings.test.ts |
Tests assignment-state notifications. |
src/vs/workbench/services/configuration/test/browser/configurationService.test.ts |
Tests configuration assignment tracking. |
src/vs/workbench/services/configuration/common/experimentalSettings.ts |
Introduces the assignment-state service. |
src/vs/workbench/services/configuration/browser/configurationService.ts |
Publishes assignment state during experiment resolution. |
src/vs/workbench/services/assignment/test/common/nullAssignmentService.ts |
Updates the null assignment service. |
src/vs/workbench/services/assignment/test/common/assignmentService.test.ts |
Tests assignment-aware treatment resolution. |
src/vs/workbench/services/assignment/common/assignmentService.ts |
Adds assignment metadata to treatment results. |
src/vs/workbench/contrib/preferences/test/browser/settingsTreeModels.test.ts |
Tests assignment-tag filtering. |
src/vs/workbench/contrib/preferences/test/browser/settingsTree.test.ts |
Updates renderer test construction. |
src/vs/workbench/contrib/preferences/test/browser/settingsSearchMenu.test.ts |
Tests the new filter menu action. |
src/vs/workbench/contrib/preferences/test/browser/settingsEditor2.test.ts |
Tests dynamic result refresh behavior. |
src/vs/workbench/contrib/preferences/common/preferences.ts |
Defines the assignment tag. |
src/vs/workbench/contrib/preferences/browser/settingsTreeModels.ts |
Adds dynamic assignment tags to settings. |
src/vs/workbench/contrib/preferences/browser/settingsSearchMenu.ts |
Adds the ExP Assigned filter action. |
src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts |
Refreshes filtered results on assignment changes. |
src/vs/workbench/contrib/chat/test/browser/feedbackSurvey/chatModelFeedbackSurveyService.test.ts |
Updates the assignment-service mock. |
src/vs/workbench/contrib/chat/test/browser/expNotification/chatExpNotification.test.ts |
Updates the assignment-service mock. |
src/vs/workbench/contrib/chat/test/browser/chatQuotaNotification.test.ts |
Updates the assignment-service mock. |
src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostPromptCacheNotification.test.ts |
Updates the assignment-service mock. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Base:
|
Vijay Upadya (vijayupadya)
left a comment
Vijay Upadya (vijayupadya)
left a comment
Contributor
There was a problem hiding this comment.
Re-posting my earlier two comments as inline threads so they're anchored to the exact lines. Nothing new here beyond the anchors — the first settingsEditor2.ts thread (line 413) is the one I'd consider must-fix.
Sandeep Somavarapu (sandy081)
requested changes
Sep 16, 2026
- Improve settings editor functionality and enhance test coverage. - Refactor assignment service logic and add new tests for edge cases. - Update configuration service and experimental settings with tests.
Copilot started reviewing on behalf of
SteVen Batten (sbatten)
September 16, 2026 16:39
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
@tag:expassignedallowing users to filter settings with ExP assignments