Automations: Ignore irrelevant unavailable providers - #336333
Open
Ulugbek Abdullaev (ulugbekna) wants to merge 1 commit into
Open
Ulugbek Abdullaev (ulugbekna) wants to merge 1 commit into
Ulugbek Abdullaev (ulugbekna) wants to merge 1 commit into
Conversation
Only let an unavailable Sessions provider make the aggregate Automation catalogue incomplete when VS Code has evidence that the provider owns automations. Preserve provider-scoped legacy evidence and remember the last authoritative Agent Host catalogue across disconnects. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 29a5d516-b4bf-4a7c-ba34-81afa14d8c6a
Copilot started reviewing on behalf of
Ulugbek Abdullaev (ulugbekna)
September 15, 2026 21:12
View session
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Sandeep Somavarapu (@sandy081)Matched files:
Ladislau Szomoru (@lszomoru)Matched files:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Agent Host ownership evidence is lost across provider recreation, allowing a previously non-empty offline catalogue to appear complete after reload.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds provider-neutral Automation ownership evidence so unavailable providers without known Automations do not mark the aggregate catalogue incomplete.
Changes:
- Introduces observable Automation ownership evidence.
- Preserves evidence across Agent Host disconnects.
- Updates aggregation behavior, documentation, and tests.
| File | Description |
|---|---|
src/vs/sessions/services/sessions/common/sessionsProvider.ts |
Adds the provider ownership-evidence contract. |
src/vs/sessions/contrib/providers/agentHost/browser/reconnectableAgentHostAutomationStore.ts |
Retains Agent Host ownership evidence while disconnected. |
src/vs/sessions/contrib/providers/agentHost/browser/agentHostAutomationStore.ts |
Derives evidence from projected Automations. |
src/vs/sessions/contrib/automations/browser/automationService.ts |
Derives evidence from persisted legacy rows. |
src/vs/sessions/contrib/automations/browser/providerAutomationService.ts |
Ignores irrelevant unavailable providers during aggregation. |
src/vs/sessions/contrib/automations/test/browser/providerAutomationService.test.ts |
Tests aggregate catalogue behavior. |
src/vs/sessions/contrib/providers/agentHost/test/browser/agentHostAutomationStore.test.ts |
Tests evidence across connection transitions. |
src/vs/sessions/AUTOMATIONS.md |
Documents the revised completeness contract. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| private readonly _runsForCache = new Map<string, IObservable<readonly IAutomationRun[]>>(); | ||
| private readonly _configurationChanged; | ||
| private readonly _authorityState = observableValue<AutomationAuthorityState>(this, { kind: 'disconnected' }); | ||
| private readonly _lastKnownHostHasAutomations = observableValue(this, false); |
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run transpile-clientnpm run typecheck-client