Fix Other Files separator spacing#324860
Open
justjavac wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Sessions “Changes” view layout math so the “Other Files” section header height used by the SplitView matches the actual CSS box model, preventing the separator/list from rendering a couple pixels too close or shifting when toggling.
Changes:
- Updated
SessionFilesWidget.HEADER_HEIGHTfrom32to34to account formargin-top (6px) + padding-y (8px) + min-height (20px).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #324457
This updates the Other Files section's header height constant to match its CSS box model:
The SplitView body height subtraction now leaves enough room for the header, avoiding the separator/list sitting 2px too close or shifting when the section is toggled.
Verification:
git diff --checknpm run typecheck-clientdoes not run locally becausetsgois not installed (sh: tsgo: command not found)