Skip to content

Fix StopLogCatMonitor cancellation#2777

Merged
ConnorQi01 merged 3 commits into
masterfrom
dev/v-peq/stopLogCatMonitor_cancel_tests
Jul 13, 2026
Merged

Fix StopLogCatMonitor cancellation#2777
ConnorQi01 merged 3 commits into
masterfrom
dev/v-peq/stopLogCatMonitor_cancel_tests

Conversation

@ConnorQi01

Copy link
Copy Markdown
Collaborator

Summary

Fix StopLogCatMonitor so cancelling the device-selection QuickPick exits cleanly instead of leaving the command pending forever.

Proposed Changes

  • Return early when the StopLogCatMonitor QuickPick selection is cancelled.
  • Preserve existing behavior for no active monitors, one active monitor, and selected monitors.
  • Add unit coverage for no monitors, single monitor, selected monitor, and cancelled selection paths.

Test Plan

pm run build

pm test (timed out after launching the VS Code test host with Error mutex already exists / EPIPE; the generated est/ExtensionTests.xml shows stopLogCatMonitorCommand ran 4 tests with 0 failures. Existing failures in that run were
n-extension commandsRegistered, packager timeout, and ipNotificationService timeout.)

Closes #2760

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@ConnorQi01

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.

@ConnorQi01

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.

@ConnorQi01 ConnorQi01 merged commit d4a3f42 into master Jul 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Fix StopLogCatMonitor QuickPick cancellation and add unit tests

2 participants