Skip to content

Use pull_request for release automation - #2031

Merged
Eduardo Villalpando Mello (edvilme) merged 2 commits into
mainfrom
release-pr-safe-trigger
Nov 18, 2026
Merged

Eduardo Villalpando Mello (edvilme) merged 2 commits into
mainfrom
release-pr-safe-trigger

Conversation

@edvilme

@edvilme Eduardo Villalpando Mello (edvilme) commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Replace pull_request_target with pull_request in .github/workflows/release-pr-release.yml, retaining the main branch filter and closed activity type.
  • Run the release job only when the PR is merged and its head/base repository IDs match.
  • Preserve the read-only workflow permissions, release job's contents: write, pinned shared action, release mode, and existing version-only/author-authorization safeguards. The read-only Release PR / Plan workflow is unchanged.

Same-repository release PRs retain the intended release-branch creation behavior. Fork-originated PRs now explicitly skip the release job, including forks opened by maintainers. No new secrets or shared-action changes are needed.

This removes the privileged event rather than requiring a pull_request_target policy exception.

Validation

  • Compared workflow changes across all eight affected repositories: identical workflow patches, changing only the event and job guard.
  • Parsed YAML comparison verifies all other workflow settings are unchanged.
  • Prettier, Actionlint 1.7.12, and git diff --check passed.
  • GitHub's @actions/expressions evaluator passed five condition cases per repository (40 total): merged/unmerged same-repository PRs, merged/unmerged forks, and a deleted fork repository.
  • Independent security review found no new security blocker.

GitHub-hosted closed-event behavior, the effective write token, and actual release-branch creation still require a controlled post-merge same-repository release PR. No release or publishing pipeline was manually triggered.

Release documentation

Updated docs/releasing.md: release PRs must originate from a branch in the upstream repository, not a fork. Head and base repositories must match; fork-originated PRs are skipped even when opened by a maintainer. Release-agent trigger references now use pull_request where applicable.

Documentation validation: Prettier, whitespace, and exact scoped-diff checks passed. The release workflow is unchanged by this documentation follow-up.

Require merged same-repository PRs while preserving existing release safeguards.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 956d3afd-ae0b-486c-a60c-3a6276c23213
@edvilme Eduardo Villalpando Mello (edvilme) added the debt Code quality issues label Nov 17, 2026
@rchiodo

Rich Chiodo (rchiodo) commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 956d3afd-ae0b-486c-a60c-3a6276c23213
@rchiodo

Copy link
Copy Markdown
Contributor

Reviewed commit: 30b965c380c0de9d2793e03d1823b12d26bcfba4

Result: 🔴 could-not-verify

Verification details

Verification: Automated verification is best effort. The PR author remains responsible for testing.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Users\rchiodo\AppData\Local\Programs\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "3efa871d0b120ead4b502339ba30dfe3036a1a0bc54f1d537714afaf430d1b20": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@rchiodo Rich Chiodo (rchiodo) added the review-auto:approved Automated review: no blocking findings (approval posted). label Nov 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@edvilme
Eduardo Villalpando Mello (edvilme) merged commit e2685bd into main Nov 18, 2026
143 of 144 checks passed
@edvilme
Eduardo Villalpando Mello (edvilme) deleted the release-pr-safe-trigger branch November 18, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Code quality issues review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants