Add basic Poetry environment lifecycle support - #1700
Draft
Eduardo Villalpando Mello (edvilme) wants to merge 1 commit into
Draft
Add basic Poetry environment lifecycle support#1700Eduardo Villalpando Mello (edvilme) wants to merge 1 commit into
Eduardo Villalpando Mello (edvilme) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6b2fe9b5-38ea-442f-b07a-b6c71134d480
Eduardo Villalpando Mello (edvilme)
marked this pull request as draft
August 7, 2026 18:12
Copilot started reviewing on behalf of
Eduardo Villalpando Mello (edvilme)
August 25, 2026 21:08
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds basic Poetry environment creation and removal for existing Python projects.
Changes:
- Creates Poetry environments using global Python 3 interpreters.
- Removes environments and clears cached selections.
- Adds localized lifecycle messages and unit coverage.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/managers/poetry/poetryManager.ts |
Implements Poetry lifecycle operations. |
src/managers/poetry/main.ts |
Supplies the output channel. |
src/common/localize.ts |
Adds lifecycle messages. |
src/test/managers/poetry/poetryManager.createRemove.unit.test.ts |
Tests creation and removal flows. |
Suppressed comments (1)
src/managers/poetry/poetryManager.ts:208
- After deleting the project mapping,
get(root)falls back toglobalEnv, but this event always reportsnew: undefined. When a different global Poetry environment exists, listeners receive a selection that disagrees with the manager's actual result. Report that fallback, except when the global environment is the one being removed.
new: undefined,
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+151
to
+155
| this._onDidChangeEnvironment.fire({ | ||
| uri: projectRoot, | ||
| old: previousEnvironment, | ||
| new: environment, | ||
| }); |
Comment on lines
+563
to
+565
| const environments = await this.api.getEnvironments('global'); | ||
| const baseEnvironment = getLatest( | ||
| environments.filter( |
Comment on lines
+554
to
+555
| if (scope === 'global' || (Array.isArray(scope) && scope.length !== 1)) { | ||
| throw new Error(PoetryStrings.create.singleProject); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation