Add setting for external uri opener - #8936
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The disabled-setting fallback opens openContext.sourceUri instead of the API-provided resolvedUri, which can result in opening the wrong target URI.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/github/externalUriOpener.ts — When the setting is disabled, openExternalUri delegates to `openWithDefaultExternalOpener(openCont… |
What changed in this PR
This PR introduces a new user setting that controls whether GitHub issue and pull request links are opened by this extension’s external URI opener (in VS Code) or left to the default external opener.
Changes:
- Add
githubPullRequests.openPullLinkssetting (default:true) and localize its description. - Gate the external URI opener priority/behavior behind the new setting.
- Extend unit coverage for the opener-priority helper when the feature is disabled.
| File | Description |
|---|---|
| src/test/common/externalUri.test.ts | Updates existing tests and adds coverage for the disabled-setting path. |
| src/github/externalUriOpener.ts | Reads the new setting to decide whether to claim/open GitHub issue/PR URLs. |
| src/common/settingKeys.ts | Adds a constant for the new setting key. |
| src/common/externalUri.ts | Updates opener-priority helper to accept an enabled flag. |
| package.nls.json | Adds localized description text for the new setting. |
| package.json | Contributes the new boolean setting to VS Code configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Henning Dieterichs (hediet)
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.