Skip to content

fix: resolve namespaced webpack sources in VS ClientApp #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
navya9singh merged 1 commit into from
Oct 5, 2026
Merged

fix: resolve namespaced webpack sources in VS ClientApp #2429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions src/targets/browser/browserPathResolver.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,10 @@ describe('BrowserPathResolver', () => {
exists(path: string): Promise<boolean> {
switch (path) {
case 'c:\\Users\\user\\Source\\Repos\\Angular Project\\ClientApp\\src\\app\\app.component.html':
case 'c:\\Users\\user\\Source\\Repos\\Angular Project\\ClientApp\\src\\components\\Component.vue':
return Promise.resolve(true);
case 'c:\\Users\\user\\Source\\Repos\\Angular Project\\wwwroot\\src\\app\\app.component.html':
case 'c:\\Users\\user\\Source\\Repos\\Angular Project\\wwwroot\\src\\components\\Component.vue':
return Promise.resolve(false);
default:
throw Error(`Unknown path ${path}`);
Expand Down Expand Up @@ -231,10 +233,26 @@ describe('BrowserPathResolver', () => {
});

[
['visualstudio', 'ClientApp'],
['vscode', 'wwwroot'],
].forEach(([client, folder]) => {
it(`returns ${folder} for ${client} if the webroot path doesn't exist and the modified path does`, async () => {
[
'visualstudio',
'webpack:///src/app/app.component.html',
'ClientApp',
'src\\app\\app.component.html',
],
[
'visualstudio',
'webpack://vue-app/src/components/Component.vue',
'ClientApp',
'src\\components\\Component.vue',
],
[
'vscode',
'webpack:///src/app/app.component.html',
'wwwroot',
'src\\app\\app.component.html',
],
].forEach(([client, url, folder, relativePath]) => {
it(`returns ${folder} for ${client} and ${url} if the webroot path doesn't exist and the modified path does`, async () => {
const webRoot = 'c:\\Users\\user\\Source\\Repos\\Angular Project\\wwwroot';

const resolver = new BrowserSourcePathResolver(
Expand All @@ -254,14 +272,13 @@ describe('BrowserPathResolver', () => {
await Logger.test(),
);

const url = 'webpack:///src/app/app.component.html';
const absolutePath = await resolver.urlToAbsolutePath({
url,
map: upcastPartial<SourceMap>({ metadata: { sourceMapUrl: '', compiledPath: 'x' } }),
});

expect(absolutePath).to.equal(
`c:\\Users\\user\\Source\\Repos\\Angular Project\\${folder}\\src\\app\\app.component.html`,
`c:\\Users\\user\\Source\\Repos\\Angular Project\\${folder}\\${relativePath}`,
);
});
});
Expand Down
2 changes: 1 addition & 1 deletion src/targets/browser/browserPathResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export class BrowserSourcePathResolver extends SourcePathResolverBase<IOptions>
);
if (
this.options.clientID === 'visualstudio'
&& fullSourceEntry.startsWith('webpack:///')
&& fullSourceEntry.startsWith('webpack://')
&& !(await this.fsUtils.exists(mappedFullSourceEntry))
&& (await this.fsUtils.exists(clientAppPath))
) {
Expand Down
Loading