Skip to content

chore: adopt merged S8 shared runtime - #625

Merged
Eduardo Villalpando Mello (edvilme) merged 1 commit into
mainfrom
chore/adopt-s8-runtime
Nov 17, 2026
Merged

Eduardo Villalpando Mello (edvilme) merged 1 commit into
mainfrom
chore/adopt-s8-runtime

Conversation

@edvilme

@edvilme Eduardo Villalpando Mello (edvilme) commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Advance only external/vscode-common-python-lsp from 664672c16ce7848f09442ce0e301279a199ceb08 to merged S8 commit 89cb5fc78d32dbdf5eb7d38d2b2bd78f0e6798a2.
  • Adopt the private settings/routing extraction behind the unchanged shared server facade; no consumer source, test, fixture, requirements, or npm dependency changes.
  • Based on main at a2c9d11e7cbc6933cfa8ea8db84b97a9ec0bebcc. The merged dependency's complete source tree matches the previously tested candidate 77240b0977e15b112599df60a436f896a5e7ef37.

Validation

  • Full unchanged native Windows pipeline passed: python -m nox --reuse-existing-virtualenvs --session install_bundled_libs tests (Python 3.13.14 bootstrap/tests; existing Python 3.10.19 bundle session). PYTHONPATH cleared; NOX_DOWNLOAD_PYTHON=never; both native sessions reused successfully.
  • Python tests: 114 passed, 0 skipped. Build tests: 23 passed, 0 skipped. Same counts as the exact consumer baseline and prior candidate. Existing nonfatal Windows file-descriptor cleanup warnings remain; no selectors or tests were weakened.
  • Post-installation isolated python -I provenance verification passed again after all tests: the complete 16-module Python filename set and file contents match exact pinned Git objects (universal-newline normalization only), including both private helpers.
  • Verified native, noneditable vscode-python-tool-internal distribution metadata, local submodule source URL, and bundled server/all loaded shared-module import origins under bundled/libs; no PYTHONPATH masking or provenance patches.
  • git diff --check passes. Consumer and detached nested submodule are clean; committed diff is gitlink-only. Native nox report saved as s8-rollout-flake8.json in the session artifacts.
  • No manual VS Code smoke testing performed. Hosted checks are reported separately by GitHub.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
@bschnurr

Copy link
Copy Markdown
Member

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

@bschnurr

Copy link
Copy Markdown
Member

Reviewed commit: 5cbebad763b1f551d358894e6cda39c4eca8f8e0

Result: 🔴 could-not-verify

Verification details

Verification: Automated verification is best effort. The PR author remains responsible for testing.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "09847a233af0976d9f062ec04c35abceabcab72ba39fe107fefdf0f690398bc9": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@bschnurr Bill Schnurr (bschnurr) added the review-auto:approved Automated review: no blocking findings (approval posted). label Nov 17, 2026
@edvilme
Eduardo Villalpando Mello (edvilme) merged commit 9e728c0 into main Nov 17, 2026
25 of 27 checks passed
@edvilme
Eduardo Villalpando Mello (edvilme) deleted the chore/adopt-s8-runtime branch November 17, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants