Repository navigation
Adopt shared runtime and pin merged lifecycle hooks - #624
Conversation
Use the shared activation facade and source-paired TypeScript/Python build paths while retaining Flake8 policy. Pin the merged microsoft/vscode-common-python-lsp#151 commit and add focused runtime/build regression checks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
|
Reviewed commit: Result: 🔴 Verification detailsVerification: Automated verification is best effort. The PR author remains responsible for testing. Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "8cee77e3c8577ae917f4acdaf0e51d7f6e11555f900f88a730ccf33777d43ac1": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found Test runs: none recorded. |
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Rich Chiodo (rchiodo)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
a2c9d11
into
main
Summary
activateToolExtensionand the runtime's awaited deactivation, retaining Flake8 settings, severity defaults, configuration watchers, commands/logging, interpreter/environment selection, and refresh policy. No extra hooks or formatter behavior are introduced.external/vscode-common-python-lspto merged commit664672c16ce7848f09442ce0e301279a199ceb08from Add optional server lifecycle hooks vscode-common-python-lsp#151. No shared source edits or machine-local submodule URLs.Final-pin validation
Using Node 24.17.0 and isolated Python 3.13.14 environments:
npm run pretest: fresh shared build, consumer TypeScript compile/typecheck, webpack bundle and ESLint; 5/5 new headless runtime/setup tests pass.nox --session install_bundled_libs --reuse-existing-virtualenvs --force-python <isolated-python>: local shared wheel rebuilt from the exact pin and installed into the bundled target.git diff --check: pass.gh aw compile issue-triagewith existing v0.93.5, followed by repository Prettier, succeeds and changes only the required workflow body hash.npm run vsce-package: production rebuild/package succeeds (350 VSIX entries).python -Iimports resolve shared/pygls/flake8 from extractedbundled/libs; no legacy distribution or npm alias is used.Limits / manual validation
Bad file descriptorwarnings without test failures.npm run format-checksingle-quoted-glob failure and pre-existing whole-file Markdown formatting failures are unchanged. Portable code/YAML formatting passes; no unrelated formatting or dependency upgrades were made.