Skip to content

Adopt shared runtime and pin merged lifecycle hooks - #624

Merged
Eduardo Villalpando Mello (edvilme) merged 1 commit into
mainfrom
refactor/s7-shared-runtime
Nov 17, 2026
Merged

Eduardo Villalpando Mello (edvilme) merged 1 commit into
mainfrom
refactor/s7-shared-runtime

Conversation

@edvilme

Copy link
Copy Markdown
Contributor

Summary

  • Adopt activateToolExtension and the runtime's awaited deactivation, retaining Flake8 settings, severity defaults, configuration watchers, commands/logging, interpreter/environment selection, and refresh policy. No extra hooks or formatter behavior are introduced.
  • Build/import the pinned submodule's public TypeScript dist entry and install Python from the same checkout through the native nox bundle path. Remove the former npm/pip registry dependencies, rebuild shared source instead of trusting stale dist, and cover runtime/setup failures with focused regressions. Retained dependency versions and the extension manifest version are unchanged; root lock metadata is aligned with the existing manifest.
  • Pin external/vscode-common-python-lsp to merged commit 664672c16ce7848f09442ce0e301279a199ceb08 from Add optional server lifecycle hooks vscode-common-python-lsp#151. No shared source edits or machine-local submodule URLs.
  • Update source-based development/triage guidance, including the matching workflow metadata regenerated with its existing pinned compiler.

Final-pin validation

Using Node 24.17.0 and isolated Python 3.13.14 environments:

  • npm run pretest: fresh shared build, consumer TypeScript compile/typecheck, webpack bundle and ESLint; 5/5 new headless runtime/setup tests pass.
  • Shared test compilation plus focused consumer environment/shared facade/server Mocha tests: 59/59 pass, including executable-child environment-removal and Windows alias regressions. VS Code/extension APIs in these tests are mocked.
  • Native nox --session install_bundled_libs --reuse-existing-virtualenvs --force-python <isolated-python>: local shared wheel rebuilt from the exact pin and installed into the bundled target.
  • Focused native Python linting/packaging/global-default tests plus build/setup tests: 24/24 pass (21 consumer + 3 setup).
  • Changed-Python Flake8/Black/isort, portable Prettier, and git diff --check: pass. gh aw compile issue-triage with existing v0.93.5, followed by repository Prettier, succeeds and changes only the required workflow body hash.
  • npm run vsce-package: production rebuild/package succeeds (350 VSIX entries).
  • Extracted-VSIX checks match all 14 shared Python modules and the embedded public index/server/facade sourcemap sources to the pinned checkout. Clean python -I imports resolve shared/pygls/flake8 from extracted bundled/libs; no legacy distribution or npm alias is used.
  • 4/4 real extracted-package stdio scenarios pass: default F401/F821 diagnostics, configured severities, disabled linting, and ignored files. Each shuts down cleanly and advertises no document formatter.
  • Separately, the coordinator ran the complete merged shared TypeScript suite: 187/187 pass (not a second full-suite run in this worktree).

Limits / manual validation

  • No VS Code UI or extension-host/manual run was performed; the above headless, mocked-API, isolated-import and actual packaged-stdio checks are distinguished deliberately.
  • Python 3.10 was unavailable; Python 3.13.14 was used. Existing Python test-harness cleanup emits Bad file descriptor warnings without test failures.
  • The existing Windows npm run format-check single-quoted-glob failure and pre-existing whole-file Markdown formatting failures are unchanged. Portable code/YAML formatting passes; no unrelated formatting or dependency upgrades were made.
  • Open for review/manual testing; auto-merge is not enabled.

Use the shared activation facade and source-paired TypeScript/Python build paths while retaining Flake8 policy. Pin the merged microsoft/vscode-common-python-lsp#151 commit and add focused runtime/build regression checks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 85ef72cc-9e26-4bc4-b1c3-55256d9bef91
@bschnurr

Bill Schnurr (bschnurr) commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

@bschnurr

Copy link
Copy Markdown
Member

Reviewed commit: c16d7ce19a2dd45be06824afae81e91653a783cc

Result: 🔴 could-not-verify

Verification details

Verification: Automated verification is best effort. The PR author remains responsible for testing.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Program Files\RedHat\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "8cee77e3c8577ae917f4acdaf0e51d7f6e11555f900f88a730ccf33777d43ac1": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@bschnurr Bill Schnurr (bschnurr) added the review-auto:approved Automated review: no blocking findings (approval posted). label Nov 17, 2026

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@edvilme
Eduardo Villalpando Mello (edvilme) merged commit a2c9d11 into main Nov 17, 2026
25 of 26 checks passed
@edvilme
Eduardo Villalpando Mello (edvilme) deleted the refactor/s7-shared-runtime branch November 17, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants