build(deps): bump the types group across 1 directory with 2 updates - #11889
Open
dependabot[bot] wants to merge 2 commits into
Open
build(deps): bump the types group across 1 directory with 2 updates#11889dependabot[bot] wants to merge 2 commits into
dependabot[bot] wants to merge 2 commits into
Conversation
Bumps the types group with 2 updates in the / directory: [@types/vscode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/vscode) and [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node). Updates `@types/vscode` from 1.125.0 to 1.134.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/vscode) Updates `@types/node` from 24.13.3 to 26.4.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/vscode" dependency-version: 1.134.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: types - dependency-name: "@types/node" dependency-version: 26.4.1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: types ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
microsoft-github-policy-service
Bot
added
the
ide
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The PR is a straightforward type-definition dependency bump with no functional code changes.
Pull request overview
Updates TypeSpec’s pnpm catalog/lockfile to pick up newer TypeScript type definitions, primarily for Node.js and the VS Code extension package.
Changes:
- Bump
@types/nodein the workspace catalog to^26.4.1. - Bump
@types/vscodeinpackages/typespec-vscodeto~1.134.0. - Regenerate
pnpm-lock.yamlto reflect the updated type packages across the repo.
File summaries
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates the workspace catalog entry for @types/node to ^26.4.1. |
| pnpm-lock.yaml | Lockfile updates reflecting the new @types/node and @types/vscode resolutions. |
| packages/typespec-vscode/package.json | Updates the VS Code extension’s @types/vscode devDependency to ~1.134.0. |
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The dependency updates appear to require a .chronus/changes/* entry (changeKind dependencies) per repo policy, and none is included in the PR.
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (2)
Previously missed (2) — in code that hasn't changed since the last review.
pnpm-workspace.yaml:74
- This dependency update changes non-excluded files but doesn't include a
.chronus/changes/*entry; per.chronus/config.yamlchangeKind: dependenciesis the expected changelog kind for dependency bumps, and these files aren't inchangedFilesexclusions, so CI may require a changeset.
pnpm-workspace.yaml:74 - The PR description says
@types/nodeis updated from 24.13.3, but the workspace catalog is actually updating it from^26.3.0to^26.4.1, which may be confusing when reviewing or auditing the change.
- Files reviewed: 2/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the types group with 2 updates in the / directory: @types/vscode and @types/node.
Updates
@types/vscodefrom 1.125.0 to 1.134.0Commits
Updates
@types/nodefrom 24.13.3 to 26.4.1Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions