Skip to content

fix: stabilize snapshots after resize - #172

Draft
cpendery (cpendery) wants to merge 1 commit into
mainfrom
fix/resize-snapshot-flake
Draft

fix: stabilize snapshots after resize#172
cpendery (cpendery) wants to merge 1 commit into
mainfrom
fix/resize-snapshot-flake

Conversation

@cpendery

Copy link
Copy Markdown
Member

Summary

  • mark emulator resizes as terminal activity so wait idle starts a fresh quiet period
  • wait for asynchronous ConPTY redraws before round-tripping resized snapshots
  • extend resize-ordering coverage to prevent the idle-clock regression

Root cause

On Windows, ConPTY can emit a full-screen redraw immediately after the emulator resize returns. The snapshot test could write its baseline before that redraw and compare it afterward, observing two valid row layouts from different frames.

Failure: https://github.com/microsoft/tui-test/actions/runs/32505599633/job/96844938742

Testing

  • cargo fmt --all -- --check
  • cargo clippy -p tui-test-rs -p tui-test-cli --all-targets --all-features -- -D warnings
  • cargo test --workspace -- --test-threads=1
  • backend parity regression test passed 30 consecutive runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant