Skip to content

fix(ci): restore worker version matrix - #1650

Merged
Cedric Vidal (cedricvidal) merged 2 commits into
mainfrom
cedricvidal-fix-workflow-run
Nov 12, 2026
Merged

Cedric Vidal (cedricvidal) merged 2 commits into
mainfrom
cedricvidal-fix-workflow-run

Conversation

@cedricvidal

@cedricvidal Cedric Vidal (cedricvidal) commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The Check Worker Versions workflow emitted an empty matrix because its setup script referenced an undefined ALL variable. This caused runs such as 43145728121 to fail after the setup job without creating worker check jobs.

Restore the explicit worker-to-version-checker matrix and add a co-located workflow test that executes the setup script for blank/all-worker and worker-specific dispatch inputs. Vitest now discovers workflow tests beside their YAML sources under .github/workflows/.

Demos

N/A - this is a GitHub Actions workflow fix with no user-visible Portal or CLI change.

Before

N/A

After

N/A

Testing

  • pinact run --check --verify-comment - passed
  • pnpm exec vitest run scripts/ci-workflow.test.ts - passed, 34 tests
  • pnpm exec vitest run .github/workflows/check-worker-versions.test.ts - passed, 4 tests

Documentation and compatibility

None. This restores the workflow's intended behavior without changing APIs, CLI behavior, dependencies, or upgrade requirements. The co-located workflow test documents the operational contract.

Checklist

  • If Portal features changed, keep CLI capabilities in sync. (N/A - no Portal change)
  • If Portal components changed, update their Storybook stories. (N/A - no Portal component change)
  • If database changes require a migration, include up() / down() and keep it CosmosDB-compatible. (N/A - no database change)
  • If dependencies changed, update the lockfile and regenerate NOTICE / NOTICE-REVIEW.txt with pnpm notice as needed. (N/A - no dependency change)
  • Video showing the behavior before the suggested change (N/A - no user-visible behavior)
  • Video showing the behavior after the suggested change (N/A - no user-visible behavior)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added area: cicd Build, test, release, and deployment pipelines. language: javascript Work involving JavaScript code, tooling, or dependencies. topic: testing Test coverage, test infrastructure, and validation quality. labels Nov 12, 2026
@github-actions

Copy link
Copy Markdown

Test Results (Node.js 22)

test: Run #586

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
3320 3320 0 0 0 0 0 1m3s

🎉 All tests passed!

Github Test Reporter

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Test Results (Node.js 22)

test: Run #587

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
3320 3320 0 0 0 0 0 1m28s

🎉 All tests passed!

Github Test Reporter

@cedricvidal
Cedric Vidal (cedricvidal) marked this pull request as ready for review November 12, 2026 03:51
@cedricvidal
Cedric Vidal (cedricvidal) merged commit 44b1b00 into main Nov 12, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: cicd Build, test, release, and deployment pipelines. language: javascript Work involving JavaScript code, tooling, or dependencies. topic: testing Test coverage, test infrastructure, and validation quality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant