Repository navigation
fix(ci): restore worker version matrix - #1650
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Test Results (Node.js 22)test: Run #586
🎉 All tests passed! |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Test Results (Node.js 22)test: Run #587
🎉 All tests passed! |
Cedric Vidal (cedricvidal)
marked this pull request as ready for review
November 12, 2026 03:51
Cedric Vidal (cedricvidal)
requested a review
from Wassim Chegham (manekinekko)
as a code owner
November 12, 2026 03:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Check Worker Versions workflow emitted an empty matrix because its setup script referenced an undefined
ALLvariable. This caused runs such as 43145728121 to fail after the setup job without creating worker check jobs.Restore the explicit worker-to-version-checker matrix and add a co-located workflow test that executes the setup script for blank/all-worker and worker-specific dispatch inputs. Vitest now discovers workflow tests beside their YAML sources under
.github/workflows/.Demos
N/A - this is a GitHub Actions workflow fix with no user-visible Portal or CLI change.
Before
N/A
After
N/A
Testing
pinact run --check --verify-comment- passedpnpm exec vitest run scripts/ci-workflow.test.ts- passed, 34 testspnpm exec vitest run .github/workflows/check-worker-versions.test.ts- passed, 4 testsDocumentation and compatibility
None. This restores the workflow's intended behavior without changing APIs, CLI behavior, dependencies, or upgrade requirements. The co-located workflow test documents the operational contract.
Checklist
up()/down()and keep it CosmosDB-compatible. (N/A - no database change)NOTICE/NOTICE-REVIEW.txtwithpnpm noticeas needed. (N/A - no dependency change)