Fix minimumReleaseAge and minimumReleaseAgeExclude for PNPM by moving…#5859
Open
aaronmaxlevy wants to merge 1 commit into
Open
Fix minimumReleaseAge and minimumReleaseAgeExclude for PNPM by moving…#5859aaronmaxlevy wants to merge 1 commit into
aaronmaxlevy wants to merge 1 commit into
Conversation
… to pnpm-workspace.yaml
aaronmaxlevy
requested review from
apostolisms,
bmiddha,
dmichon-msft,
iclanton,
jxanthony and
octogonz
as code owners
Author
|
@microsoft-github-policy-service agree company="Reve AI" |
iclanton
approved these changes
Jul 13, 2026
| { | ||
| "changes": [ | ||
| { | ||
| "comment": "Fix minimumReleaseAge and minimumReleaseAgeExclude in pnpm-config.json being silently ignored because they were written to package.json instead of pnpm-workspace.yaml", |
Member
There was a problem hiding this comment.
Suggested change
| "comment": "Fix minimumReleaseAge and minimumReleaseAgeExclude in pnpm-config.json being silently ignored because they were written to package.json instead of pnpm-workspace.yaml", | |
| "comment": "Fix `minimumReleaseAge` and `minimumReleaseAgeExclude` in `pnpm-config.json` being silently ignored because they were written to package.json instead of `pnpm-workspace.yaml`", |
| workspaceYaml.allowBuilds = this._allowBuilds; | ||
| } | ||
|
|
||
| if (this._minimumReleaseAge !== undefined) { |
Member
There was a problem hiding this comment.
What happens if this is set to undefined? Is the field omitted from the output YAML in that case? If it is, we don't need this check.
Same question about minimumReleaseAgeExclude. Can that just be set to an empty array? Would that cause any issues?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to pnpm-workspace.yaml
Summary
Fixes #5752
Details
This fixes support for PNPM
minimumReleaseAgeandminimumReleaseAgeExcludeby writing them to pnpm-workspace.yaml instead. There is an existing PR open for this #5798 , however that PR moves it to .npmrc instead, whereas according to @iclanton in #5798 (comment) it is preferable to put it in pnpm-workspace.yaml instead (which I agree with). It has been two weeks since that comment was left on #5798 and it hasn't been addressed there, so I figured I'd file my own PR, given that there are real security implications to this setting not working currently. Apologies if this is undesired.How it was tested
Ran the Rush test suite and validated outputs.
Impacted documentation
N/A