fix(codegen): accept React.ComponentRef in command first-arg - #3078
Open
Ramon Claudio (ramonclaudio) wants to merge 1 commit into
Open
Conversation
React 19 renamed `React.ElementRef` to `React.ComponentRef`. The TypeScript commands parser only accepts `ElementRef`, so a NativeCommand whose first arg is typed as `React.ComponentRef` fails codegen with "The first argument of method <name> must be of type React.ElementRef<>". Forward-ports react#54274 (by Mike Hardy): accept both names and update the error message. This unblocks libraries that moved to `ComponentRef`, like react-native-screens 4.26, whose command spec currently breaks the macOS codegen.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Ramon Claudio (ramonclaudio)
marked this pull request as ready for review
August 7, 2026 13:56
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of react#54274.
React 19 renamed
React.ElementReftoReact.ComponentRef, and the TypeScript commands parser here only acceptsElementRef, so a command typed withComponentReffails codegen.react-nativemain already accepts both, butreact-native-macos0.81 does not.This shows up with
react-native-screens@4.26, which types a command's first argument asReact.ComponentRef<>.ElementRefstill works, so existing command specs continue to pass.Test plan
yarn jest packages/react-native-codegen --watchman=false(66 suites, 2,949 tests, and 1,128 snapshots pass)git diff --check origin/0.81-stable...HEAD