docs: complete reporter unions and mode lists, fix version annotations - #42521
Closed
Ashraf Ali (ashrafiucse) wants to merge 2 commits into
Closed
docs: complete reporter unions and mode lists, fix version annotations#42521Ashraf Ali (ashrafiucse) wants to merge 2 commits into
Ashraf Ali (ashrafiucse) wants to merge 2 commits into
Conversation
- add 'blob' to the BuiltInReporter union in TestConfig and FullConfig - add 'perfetto' to the merge-reports --reporter list - list the missing retain-on-first-failure and retain-on-failure-and-retries trace modes - list the missing on-all-retries, retain-on-first-failure and retain-on-failure-and-retries video modes - FullConfig.configFile is undefined, not an empty string, without a config file - colorScheme also supports 'no-preference' - maskColor was introduced in v1.35, not v1.34 - normalize malformed 'since' version strings
The hand-written override for FullConfig.reporter omitted 'blob' even though it is a built-in reporter and ReporterDescription accepts it.
Collaborator
|
Ashraf Ali (@ashrafiucse) Please file an issue before sending a PR, according to the contributing guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blobto theBuiltInReporterunions inTestConfig/FullConfigdocs and to theFullConfig.reportertype override (it is inbuiltInReportersandReporterDescription, but missing from both unions)perfettoto the merge-reports--reporterlistretain-on-first-failureandretain-on-failure-and-retriestrace modes andon-all-retries,retain-on-first-failure,retain-on-failure-and-retriesvideo modes (all shipped, announced in release notes)FullConfig.configFileisundefinedwithout a config file, not an empty stringcolorSchemealso supports'no-preference'maskColorwas introduced in v1.35 (per release notes and the shared template), not v1.34sinceversion strings (v.1.30,1.30,1.46)