fix(types): expose signal option of Locator.elementHandle - #42520
Closed
Ashraf Ali (ashrafiucse) wants to merge 1 commit into
Closed
fix(types): expose signal option of Locator.elementHandle#42520Ashraf Ali (ashrafiucse) wants to merge 1 commit into
Ashraf Ali (ashrafiucse) wants to merge 1 commit into
Conversation
The signal option is documented and honored by the client implementation but was missing from the generated types because the hand-written override did not list it.
Collaborator
|
Ashraf Ali (@ashrafiucse) Please file an issue before sending a PR, according to the contributing guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signaloption to the hand-writtenLocator.elementHandleoverride so it shows up in the generated typesclient/locator.tspassesTimeoutOptionsintoframe.waitForSelector), but the override literal omitted it and suppressed the doc-generated signature