docs: fix incorrect defaults and broken samples in guides - #42519
Open
Ashraf Ali (ashrafiucse) wants to merge 2 commits into
Open
docs: fix incorrect defaults and broken samples in guides#42519Ashraf Ali (ashrafiucse) wants to merge 2 commits into
Ashraf Ali (ashrafiucse) wants to merge 2 commits into
Conversation
The default launch timeout is DEFAULT_PLAYWRIGHT_LAUNCH_TIMEOUT = 180000 (3 minutes) in packages/isomorphic/time.ts, not 30000 (30 seconds).
- dialogs: fix misplaced parenthesis in the python async sample and zero-argument dialog handlers in the beforeunload samples - service workers: config sample now sets serviceWorkers to 'block' as described by the surrounding text - handles: use Array.push instead of List.add in the java and csharp samples since the code runs in the page - test-parallel: worker index starts with 0, not 1 - blob reporter: default file name has no project segment - test-configuration: show the real default testMatch glob - input: fix invalid time input value in the csharp sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
180000(3 minutes), matchingDEFAULT_PLAYWRIGHT_LAUNCH_TIMEOUTinpackages/isomorphic/time.ts'block'as the surrounding text instructsArray.pushinstead ofList.addin the java/csharphandles.mdsamples (the code runs in the page)0, not1(workerHost.tsassignslastWorkerIndex++starting from 0)report-<hash>-<shard_number>.zip, no project segment (reporters/blob.ts)testMatchglob instead of an outdated regex13:15time value in the csharp input sample