fix(trace-viewer): show full URL when navigation leaves baseURL - #42502
Closed
Ravi Kumar Gupta (EDWARD-012) wants to merge 1 commit into
Closed
fix(trace-viewer): show full URL when navigation leaves baseURL#42502Ravi Kumar Gupta (EDWARD-012) wants to merge 1 commit into
Ravi Kumar Gupta (EDWARD-012) wants to merge 1 commit into
Conversation
Action titles that render a {url} param always dropped the origin.
Keep path-only titles for same-origin navigations relative to the
context baseURL, and print the full URL when the origin differs.
Fixes: microsoft#42473
Co-authored-by: Martin Olsson <molsson@recordedfuture.com>
Author
|
@microsoft-github-policy-service agree |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{url}param always dropped the origin viaprotocolFormatterbaseURLoriginbaseURLthrough formatter call sites (trace viewer, recorder, debugger, screencast, trace CLI)Fixes #42473
Credit: approach based on <script>alert(1)</script>🪅 (@rf-molsson)'s draft commit
462a0fa.Test plan
npx playwright test --config=tests/library/playwright.config.ts tests/library/unit/protocol-formatter.spec.tsnpx playwright test --config=tests/library/playwright.config.ts --project=chromium-library -g "navigating away from the base url"