fix(windows): hide console window when launching headless browsers#41633
Open
triemerge wants to merge 1 commit into
Open
fix(windows): hide console window when launching headless browsers#41633triemerge wants to merge 1 commit into
triemerge wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The tricky part here is that
launchProcess()is shared by all browser launches, including headed ones like codegen and Inspector. SettingwindowsHideunconditionally would hide those too, so it needs to be opt-in and only kick in for headless launches.While at it, also applied it to the ffmpeg and taskkill spawns since neither of those should be showing a console window either.
Fixes #41630