fix: keep reused browser when stopping the debugging - #808
Open
Ashraf Ali (ashrafiucse) wants to merge 1 commit into
Open
fix: keep reused browser when stopping the debugging#808Ashraf Ali (ashrafiucse) wants to merge 1 commit into
Ashraf Ali (ashrafiucse) wants to merge 1 commit into
Conversation
Stopping a debug session tears down the debugged test process, which also tears down its browser page. When the page count then dropped to zero, the extension killed the reused browser backend as well, closing the browser instead of keeping it around for inspection and recording. Keep the backend alive after a debug run with "Show Browser" enabled, both when the run ends and when a late page-count update arrives. Fixes: microsoft/playwright#37822
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onDidRunTests()and the late_pageCountChanged(0)update both killed the reused browser backend, closing the browser instead of keeping it for inspection and recordingAddresses microsoft/playwright#37822 (the issue is closed by the root-cause fix below; this hardens the extension side and covers workspaces pinned to older cores).
The root cause (pages torn down with the connection) is fixed core-side: microsoft/playwright#42461
Related: #807 fixes stale recorder actions inserted while editing during "Record at cursor" (microsoft/playwright#42218).