fix(page-fixture): support multi-browser runs when page fixture is overridden - #322
Open
techbefore07-ops wants to merge 1 commit into
Open
techbefore07-ops wants to merge 1 commit into
techbefore07-ops wants to merge 1 commit into
Conversation
…erridden Fixes microsoft#172 — when a test overrides the 'page' fixture, multi-browser parametrization (--browser chromium --browser firefox) was skipped because pytest_generate_tests only checked for 'browser_name' in fixturenames. Add _PLAYWRIGHT_FIXTURES set covering all known Playwright fixtures and check for any of them to trigger multi-browser parametrization. Co-authored-by: openhands <openhands@all-hands.dev>
techbefore07-ops
force-pushed
the
fix/page-fixture-multi-browser
branch
from
September 15, 2026 13:40
4835d8e to
9d495e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #172 — when a test overrides the 'page' fixture, multi-browser parametrization (--browser chromium --browser firefox) was skipped because pytest_generate_tests only checked for 'browser_name' in fixturenames.
Add _PLAYWRIGHT_FIXTURES set covering all known Playwright fixtures and check for any of them to trigger multi-browser parametrization.