Repository navigation
[WebGPU] Upgrade Dawn to the latest - #32686
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/run bots |
|
PTAL, thanks! Jiajia Qin (@qjia7) Jie Chen (@jchen10) |
There was a problem hiding this comment.
🟡 Changes recommended
Update the governance manifest, correct the malformed patch hunk, and resolve the Windows DXIL packaging dependency.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Upgrades the bundled Dawn dependency for WebGPU and removes obsolete dxil.dll staging.
Changes:
- Pins Dawn to
v20260916.214021. - Refreshes the Dawn BinSkim patch.
- Removes DXIL packaging from Windows Python, Node.js, Java, and WebGPU builds.
File summaries
| File | Summary |
|---|---|
cmake/deps.txt |
Updates the Dawn archive and hash; the governance manifest also requires updating. |
cmake/patches/dawn/dawn_binskim.patch |
Refreshes the BinSkim patch, but its hunk header is malformed. |
cmake/onnxruntime_providers_webgpu.cmake |
Removes DXIL staging while downstream Windows packaging still expects the DLL. |
cmake/onnxruntime_python.cmake |
Removes obsolete DXIL packaging. |
cmake/onnxruntime_nodejs.cmake |
Removes obsolete Node.js DXIL packaging. |
cmake/onnxruntime_java.cmake |
Removes obsolete Java DXIL packaging. |
Review details
Suppressed comments (1)
cmake/deps.txt:62
- Rolling the Dawn archive without updating
cgmanifests/webgpu/cgmanifest.webgpu.jsonleaves the WebGPU Component Governance manifest on the old Dawn commit and dependency graph. The manifest's maintenance instructions require its root and Dawn-derived registrations to matchcmake/deps.txt; otherwise NOTICE/component scans can report the wrong source (and the stale-pin validator cannot pass once its Dawn extraction is corrected). Please update/regenerate that manifest forv20260916.214021in this change.
dawn;https://github.com/google/dawn/archive/refs/tags/v20260916.214021.zip;514e914f23a0787213c89eed879f74b5e275690d
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
The request was received. Approve workflow runs. Thanks. |
|
/run bots |
|
The request was received. Approve workflow runs. Thanks. |
|
|
/run bots |
|
The request was received. Approve workflow runs. Thanks. |
|
I think there are a few other places which still copy or refer to dxil.dll. e.g.:
do those need to be updated too? |
if this is referring to |
|
/run bots |
|
The request was received. Approve workflow runs. Thanks. |
Yes, I have updated them. Thanks. |
|
/run bots |
|
The request was received. Approve workflow runs. Thanks. |
|
/run bots |
|
The request was received. Approve workflow runs. Thanks. |
|
could you please also update this SwiftShader commit to match the one pinned by the new Dawn version? |
|
/run bots |
|
Just curious, do we need to update these hashes manually now? I think we should maintain some script to make the upgrade easier. |
|
The request was received. Approve workflow runs. Thanks. |
I agree, that would make things much easier. |
|
PTAL again, thanks! Jiajia Qin (@qjia7) Edward Chen (@edgchen1) |
LGTM, please wait for Edward Chen (@edgchen1)'s review. Thanks. |
fb8905b
into
microsoft:main
Description
This patch updates Dawn to the latest version.
Motivation and Context
D3D12 XMX support for ORT-EP-WebGPU Python wheels will be added in another patch after the upgrade of Dawn.