CHORE: add shift-left secret scanning to PR validation (test)#674
Draft
bewithgaurav wants to merge 1 commit into
Draft
CHORE: add shift-left secret scanning to PR validation (test)#674bewithgaurav wants to merge 1 commit into
bewithgaurav wants to merge 1 commit into
Conversation
adds a SecretScan job to the pr-validation pipeline that runs the 1ES Secret Scanning (SEC101/SPMI) engine on every PR, so credential leaks like SEC101/037 SqlLegacyCredentials are caught pre-merge instead of at the GitHub->ADO sync. includes a clearly-fake planted probe fixture to verify detection end-to-end; both the fixture and (pending decision) the job are test scaffolding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.h: 59.9%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.connection.connection.cpp: 76.2%
mssql_python.pybind.ddbc_bindings.cpp: 76.2%
mssql_python.__init__.py: 77.3%
mssql_python.row.py: 77.6%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.connection.py: 83.6%
mssql_python.logging.py: 85.5%🔗 Quick Links
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
draft / test — do not merge. proving shift-left secret scanning on PR validation.
adds a
SecretScanjob toeng/pipelines/pr-validation-pipeline.ymlthat runs1ESSecretScanning@1(the SEC101 / SPMI engine, same family as the ADO push-protectionSEC101/037 SqlLegacyCredentialssignal) +PostAnalysis@2to fail the build on any finding. goal: catch credential leaks at PR time, pre-merge, instead of surfacing later at the GitHub→ADO sync push-protection gate.tests/_secretscan_probe.txtis a clearly-fake, non-live Azure-SQL-cred-shaped string planted only to verify detection end-to-end. expected result: theSecret Scanleg fails on this probe. once detection is confirmed, the probe file is removed and the scan should pass.both the probe and the placement of the job are test scaffolding for evaluation.